Skip to content

Backport of some GenVector fixes #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpiparo merged 2 commits into from
Apr 13, 2017
Merged

Backport of some GenVector fixes #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c8bba
Attempt to fix roottest_root_math_genvector_coordinates4D on ARM64.
Axel-Naumann Feb 17, 2017
b1d1a71
Fix for the precision on ARM64
peremato Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion math/genvector/test/coordinates4D.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,8 @@ int coordinates4D (bool testAll = false) {
// test cases with zero mass

// tick should be p /sqrt(eps) ~ 4 /sqrt(eps)
ret |= test4D (PxPyPzMVector ( 1., 2., 3., 0.) , 4./std::sqrt(std::numeric_limits<double>::epsilon()) );
// take a factor 1.5 in ticks to be conservative
ret |= test4D (PxPyPzMVector ( 1., 2., 3., 0.) , 1.5 * 4./std::sqrt(std::numeric_limits<double>::epsilon()) );

// this test fails in some machines (skip by default)
if (!testAll) return ret;
Expand Down
5 changes: 4 additions & 1 deletion math/genvector/test/testGenVector.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,10 @@ int testTransform3D() {
iret |= compare( r.Theta(), err2.Theta(),"transf rot theta",1 );
iret |= compare( r.Psi(), err2.Psi(),"transf rot psi",1 );

iret |= compare( v == vvv2, 1,"eq transf g vec",1 );
//iret |= compare( v == vvv2, 1,"eq transf g vec",1 );
iret |= compare( v.X(), vvv2.X(),"eq transf g vec",4 );
iret |= compare( v.Y(), vvv2.Y(),"eq transf g vec",1 );
iret |= compare( v.Z(), vvv2.Z(),"eq transf g vec",1 );

// create from other rotations
RotationZYX rzyx(r);
Expand Down