Skip to content

Conversation

@peremato
Copy link
Contributor

PyROOT cannot read/write C++ class fields of Double32_t. Added the missing converter.

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=ON -Dimt=OFF

@peremato
Copy link
Contributor Author

The clang-format got it all wrong :-(

@vgvassilev
Copy link
Member

Probably we need to change the coding conventions there...

@pcanal
Copy link
Member

pcanal commented Apr 20, 2017

This kind kind of 'hand formatted' code can/should be surrounded with

// clang-format off
... array declaration
// clang-format on

Probably we need to change the coding conventions there...

I don't think clang-format has a switch for this one ... and we already backtracked on the prior coding convention requesting alignment of operator= across lines (the majority spoke against it), so I don't see this alignment becoming a rule ...

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=ON -Dimt=OFF

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1011/native, slc6/gcc49, slc6/gcc62, ubuntu14/native and CMake flags -Dccache=ON -Dimt=OFF

@peremato peremato merged commit e2e19d6 into root-project:master Apr 20, 2017
peremato added a commit that referenced this pull request Apr 20, 2017
* Fix for ROOT-8732 - PyROOT cannot read/write C++ class fields of Double32_t

* Try to please clang-format

* Again :-(
@pcanal
Copy link
Member

pcanal commented Apr 20, 2017

Hi Pere,

Could you also add a regression test for this behavior?

Thanks,
Philippe.

gganis pushed a commit to gganis/root that referenced this pull request Apr 25, 2017
* Fix for ROOT-8732 - PyROOT cannot read/write C++ class fields of Double32_t

* Try to please clang-format

* Again :-(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants