-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix for ROOT-8732 #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ROOT-8732 #517
Conversation
|
Starting build on |
|
The clang-format got it all wrong :-( |
|
Probably we need to change the coding conventions there... |
|
This kind kind of 'hand formatted' code can/should be surrounded with // clang-format off
... array declaration
// clang-format on
I don't think clang-format has a switch for this one ... and we already backtracked on the prior coding convention requesting alignment of operator= across lines (the majority spoke against it), so I don't see this alignment becoming a rule ... |
|
Starting build on |
|
Starting build on |
* Fix for ROOT-8732 - PyROOT cannot read/write C++ class fields of Double32_t * Try to please clang-format * Again :-(
|
Hi Pere, Could you also add a regression test for this behavior? Thanks, |
* Fix for ROOT-8732 - PyROOT cannot read/write C++ class fields of Double32_t * Try to please clang-format * Again :-(
PyROOT cannot read/write C++ class fields of Double32_t. Added the missing converter.