Skip to content

Coverity fixes 82576, 82575, 68746, 68745, 68856, 61279, 61577 #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 8 commits into from
May 3, 2017
Merged

Coverity fixes 82576, 82575, 68746, 68745, 68856, 61279, 61577 #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d87697
coverity 82576,82575
harveyj1953 Mar 17, 2017
c39fbdd
coverity 68746,68745
harveyj1953 Mar 17, 2017
3929101
coverity 68856
harveyj1953 Mar 17, 2017
220e9b7
removed duplicate increment in for loop
harveyj1953 Apr 12, 2017
7a6b3a5
coverity 61279: fix copy/paste error
harveyj1953 Apr 25, 2017
8238701
coverity 61577: fix resource leak delete [] c
harveyj1953 Apr 25, 2017
3b3d9e0
clang-format.
vgvassilev Apr 26, 2017
ec65772
Declare variable, a merge leftover issue.
vgvassilev Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion math/mathmore/test/testInterpolation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void interpolate( const ROOT::Math::Interpolator & itp, bool drawSame = false )
double xi = 0.;
Float_t xcoord[n], ycoord[n];

for ( i = 0; i < 50; ++i) {
for (i = 0; i < n; ++i) {
xi = 0.2 * i;
// JH replacing for ( double xi = 0; xi < 10.01; xi += 0.2) {
xcoord[i] = xi;
Expand Down
4 changes: 4 additions & 0 deletions test/stressHistogram.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10229,6 +10229,10 @@ int stressHistogram()
<< gROOT->GetGitBranch() << "@" << gROOT->GetGitCommit() << std::endl;
std::cout <<"****************************************************************************\n";

if (cleanHistos) {
delete ht2;
delete htp2;
}
return GlobalStatus;
}

Expand Down
10 changes: 5 additions & 5 deletions test/stressLinear.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2249,11 +2249,11 @@ void spstress_matrix_fill(Int_t rsize,Int_t csize)
{
Bool_t ok = kTRUE;

if (csize < 4) {
Error("spstress_matrix_fill","rsize should be >= 4");
ok = kFALSE;
StatusPrint(2,"Filling, Inserting, Using",ok);
return;
if (rsize < 4) {
Error("spstress_matrix_fill", "rsize should be >= 4");
ok = kFALSE;
StatusPrint(2, "Filling, Inserting, Using", ok);
return;
}

if (csize < 4) {
Expand Down
1 change: 1 addition & 0 deletions tmva/tmva/inc/TMVA/DNN/Layer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ TLayer<Architecture_t>::TLayer(const TLayer &layer)
{
Architecture_t::Copy(fWeights, layer.GetWeights());
Architecture_t::Copy(fBiases, layer.GetBiases());
fDropoutProbability = 0.;
}

//______________________________________________________________________________
Expand Down
1 change: 1 addition & 0 deletions tmva/tmva/src/HyperParameterOptimisation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
TMVA::HyperParameterOptimisationResult::HyperParameterOptimisationResult()
: fROCAVG(0.0), fROCCurves(std::make_shared<TMultiGraph>())
{
fROCAVG = 0.;
}

TMVA::HyperParameterOptimisationResult::~HyperParameterOptimisationResult()
Expand Down
1 change: 1 addition & 0 deletions tmva/tmvagui/src/rulevisHists.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,4 +263,5 @@ void TMVA::rulevisHists( TDirectory *rfdir, TDirectory *vardir, TDirectory *corr
TString fname = Form( "plots/%s_c%i", outputName.Data(), countCanvas+1 );
TMVAGlob::imgconv( c[countCanvas], fname );
}
delete[] c;
}