[cxxmodules] Teach cling to build modules; Build dependent modules explicitly. #5521

vgvassilev · 2020-05-01T14:45:50Z

This would allow CMSSW to build its third party modules by calling:

rootcling bare-cling -xc++ -I${ROOTSYS}/etc -I ${headers_location}
                                 -fmodules -Xclang -emit-module -fmodule-name=tinyxml2
                                 -fmodules-cache-path=${CMSSW_LIBDIR} -o ${module_file_location}
                                 ${headers_location}/module.modulemap

This commit has several issues one is that it does not order the dependencies so if libc.pcm goes out of date the build system does not regenerate std.pcm.

cc: @oshadura, @davidlange6, @smuzaffar

phsft-bot · 2020-05-01T14:46:00Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

cmake/modules/RootMacros.cmake

phsft-bot · 2020-05-01T14:52:21Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-01T14:52:19.447Z] ninja: error: 'etc/cling/module.modulemap', needed by 'lib/Cling_Runtime.pcm', missing and no known rule to make it

phsft-bot · 2020-05-01T15:03:33Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-01T15:03:32.166Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-01T15:03:32.423Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:968 (message):

phsft-bot · 2020-05-01T15:10:39Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-01T15:10:37.804Z] ninja: error: 'etc/cling/module.modulemap', needed by 'lib/Cling_Runtime.pcm', missing and no known rule to make it

phsft-bot · 2020-05-04T08:26:02Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-04T08:29:18Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-04T08:29:16.788Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-04T08:29:17.045Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:968 (message):

phsft-bot · 2020-05-07T17:56:12Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-07T17:57:43Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-07T17:57:42.102Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-07T17:57:42.102Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-07T18:01:41Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-07T18:01:39.948Z] ninja: error: 'etc/cling/module.modulemap', needed by 'lib/Cling_Runtime.pcm', missing and no known rule to make it

phsft-bot · 2020-05-07T18:12:03Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-07T18:12:00.973Z] ninja: error: 'etc/cling/module.modulemap', needed by 'lib/Cling_Runtime.pcm', missing and no known rule to make it

phsft-bot · 2020-05-07T19:56:06Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-07T19:58:33Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-07T19:58:30.450Z] ninja: error: 'etc/cling/module.modulemap', needed by 'lib/Cling_Runtime.pcm', missing and no known rule to make it

phsft-bot · 2020-05-07T19:59:17Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-07T19:59:15.593Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-07T19:59:15.851Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-07T20:34:59Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 957 more

vgvassilev · 2020-05-08T05:03:20Z

@phsft-bot build!

phsft-bot · 2020-05-08T05:03:28Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-08T05:05:13Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-08T05:05:12.418Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-08T05:05:12.677Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-08T05:05:38Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-08T05:05:35.893Z] ninja: error: 'etc/cling/module.modulemap', needed by 'lib/Cling_Runtime.pcm', missing and no known rule to make it

phsft-bot · 2020-05-08T05:27:14Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-08T05:08:55.195Z] CMake Error at C:/build/workspace/root-pullrequests-build/build/TBB-prefix/src/TBB-stamp/TBB-build-Release.cmake:49 (message):

phsft-bot · 2020-05-08T09:35:31Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

vgvassilev · 2020-05-08T11:33:22Z

@phsft-bot build!

phsft-bot · 2020-05-08T11:33:50Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-08T11:33:49.947Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1515 (message):
[2020-05-08T11:33:49.948Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-08T11:38:16Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-08T11:38:15.106Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-08T11:38:15.363Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-08T11:52:03Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 958 more

phsft-bot · 2020-05-09T19:03:33Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-09T19:05:17Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-09T19:05:16.274Z] CMake Error at cmake/modules/RootMacros.cmake:287 (message):
[2020-05-09T19:05:16.532Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-09T19:16:12Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 957 more

phsft-bot · 2020-05-09T19:20:12Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 942 more

phsft-bot · 2020-05-09T20:05:36Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-09T20:07:15Z

Build failed on mac1015/cxx17.
Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-09T20:07:12.655Z] CMake Error at cmake/modules/RootMacros.cmake:288 (message):
[2020-05-09T20:07:12.912Z] CMake Error at /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:988 (message):

phsft-bot · 2020-05-09T20:17:01Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 956 more

phsft-bot · 2020-05-09T20:23:25Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 946 more

phsft-bot · 2020-05-09T20:27:42Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-09T20:40:19Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 956 more

phsft-bot · 2020-05-09T20:44:51Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

[2020-05-09T20:44:17.603Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:118:11: error: header 'stdarg.h' not found
[2020-05-09T20:44:17.603Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:1:1: error: unknown type name 'module'
[2020-05-09T20:44:17.603Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:1:29: error: use of undeclared identifier 'system'
[2020-05-09T20:44:17.604Z] :1:38: error: use of undeclared identifier 'extern_c'module AppleTextureEncoder [system] [extern_c] {
[2020-05-09T20:44:17.870Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:2:2: error: use of undeclared identifier 'header'
[2020-05-09T20:44:17.870Z] :2:2: error: use of undeclared identifier 'header'
[2020-05-09T20:44:17.870Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:2:2: error: use of undeclared identifier 'header'
[2020-05-09T20:44:17.870Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:5:2: error: expected ';' after top level declarator
[2020-05-09T20:44:17.870Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:5:2: error: expected ';' after top level declarator
[2020-05-09T20:44:17.870Z] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/module.modulemap:5:2: error: expected ';' after top level declarator

And 117 more

phsft-bot · 2020-05-09T20:51:54Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

phsft-bot · 2020-05-11T09:05:23Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-11T09:36:04Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 957 more

…plicitly. This allows external users to call rootcling as: rootcling bare-cling -xc++ -I${ROOTSYS}/etc -I ${headers_location} -fmodules -Xclang -emit-module -fmodule-name=tinyxml2 -fmodules-cache-path=${CMSSW_LIBDIR} -o ${module_file_location} ${headers_location}/module.modulemap

This will allow us to generalize it to resolve C headers as well.

New versions of OSX has libc in the sdk path and not at the usual /usr/include. Detect the location in a similar way to detection of the C++ headers. This solves the issue with the failure to build the Darwin.pcm file and the diagnostic that there is no module.modulemap for osx 10.15 in /usr/include/

phsft-bot · 2020-05-12T10:49:54Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-05-12T11:13:46Z

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 956 more

phsft-bot · 2020-05-12T11:27:42Z

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

phsft-bot · 2020-05-12T11:32:46Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

And 956 more

vgvassilev requested review from Axel-Naumann, oshadura and pcanal as code owners May 1, 2020 14:45

vgvassilev commented May 1, 2020

View reviewed changes

cmake/modules/RootMacros.cmake Outdated Show resolved Hide resolved

vgvassilev force-pushed the rootcling_barecling_external_modules branch from 022148b to a879994 Compare May 4, 2020 08:25

oshadura assigned vgvassilev May 4, 2020

vgvassilev force-pushed the rootcling_barecling_external_modules branch from a879994 to bec0e46 Compare May 7, 2020 17:56

vgvassilev changed the title ~~WIP: [cxxmodules] Teach cling to build modules; Build dependent modules explicitly.~~ [cxxmodules] Teach cling to build modules; Build dependent modules explicitly. May 7, 2020

vgvassilev force-pushed the rootcling_barecling_external_modules branch from bec0e46 to fdca56d Compare May 7, 2020 19:55

vgvassilev force-pushed the rootcling_barecling_external_modules branch from 84c61c7 to af6bfc7 Compare May 9, 2020 20:05

vgvassilev force-pushed the rootcling_barecling_external_modules branch from af6bfc7 to 5eed354 Compare May 9, 2020 20:27

vgvassilev added 4 commits May 12, 2020 10:49

[cling] Move C++ header location detection in a separate function.

c20406b

This will allow us to generalize it to resolve C headers as well.

Fix osx

e627c0b

vgvassilev force-pushed the rootcling_barecling_external_modules branch from 25c9029 to e627c0b Compare May 12, 2020 10:49

ferdymercury added in:Core Libraries in:Cling labels Apr 15, 2024

[cxxmodules] Teach cling to build modules; Build dependent modules explicitly. #5521

Are you sure you want to change the base?

[cxxmodules] Teach cling to build modules; Build dependent modules explicitly. #5521

Uh oh!

Conversation

vgvassilev commented May 1, 2020

Uh oh!

phsft-bot commented May 1, 2020

Uh oh!

Uh oh!

phsft-bot commented May 1, 2020

Errors:

Uh oh!

phsft-bot commented May 1, 2020

Errors:

Uh oh!

phsft-bot commented May 1, 2020

Errors:

Uh oh!

phsft-bot commented May 4, 2020

Uh oh!

phsft-bot commented May 4, 2020

Errors:

Uh oh!

phsft-bot commented May 7, 2020

Uh oh!

phsft-bot commented May 7, 2020

Errors:

Uh oh!

phsft-bot commented May 7, 2020

Errors:

Uh oh!

phsft-bot commented May 7, 2020

Errors:

Uh oh!

phsft-bot commented May 7, 2020

Uh oh!

phsft-bot commented May 7, 2020

Errors:

Uh oh!

phsft-bot commented May 7, 2020

Errors:

Uh oh!

phsft-bot commented May 7, 2020

Failing tests:

Uh oh!

vgvassilev commented May 8, 2020

Uh oh!

phsft-bot commented May 8, 2020

Uh oh!

phsft-bot commented May 8, 2020

Errors:

Uh oh!

phsft-bot commented May 8, 2020

Errors:

Uh oh!

phsft-bot commented May 8, 2020

Errors:

Uh oh!

phsft-bot commented May 8, 2020

Failing tests:

Uh oh!

vgvassilev commented May 8, 2020

Uh oh!

phsft-bot commented May 8, 2020

Errors:

Uh oh!

phsft-bot commented May 8, 2020

Errors:

Uh oh!

phsft-bot commented May 8, 2020

Failing tests:

Uh oh!

phsft-bot commented May 9, 2020

Uh oh!

phsft-bot commented May 9, 2020

Errors:

Uh oh!

phsft-bot commented May 9, 2020

Failing tests: