Skip to content

Conversation

@eguiraud
Copy link
Contributor

@eguiraud eguiraud commented May 6, 2020

Should fix errors such as those at https://bit.ly/2W6cZoc :

/home/sftnight/build/night/LABEL/ROOT-centos8/SPEC/default/V/master/build/include/ROOT/RDF/RInterface.hxx:2363:25:
error: no viable conversion from
'shared_ptr<ROOT::Detail::RDF::RCustomColumn<ROOT::VecOps::RVec<ROOT::VecOps::RVec<unsigned
long> > (*)(const ROOT::VecOps::RVec<float> &, const
ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<float> &, const
ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<int> &),
ROOT::Detail::RDF::CustomColExtraArgs::None>>' to 'const
shared_ptr<RDFDetail::RCustomColumnBase>'
      newCols.AddColumn(newColumn, name);
                              ^~~~~~~~~

Should fix errors such as those at https://bit.ly/2W6cZoc :

/home/sftnight/build/night/LABEL/ROOT-centos8/SPEC/default/V/master/build/include/ROOT/RDF/RInterface.hxx:2363:25:
error: no viable conversion from
'shared_ptr<ROOT::Detail::RDF::RCustomColumn<ROOT::VecOps::RVec<ROOT::VecOps::RVec<unsigned
long> > (*)(const ROOT::VecOps::RVec<float> &, const
ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<float> &, const
ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<int> &),
ROOT::Detail::RDF::CustomColExtraArgs::None>>' to 'const
shared_ptr<RDFDetail::RCustomColumnBase>'
      newCols.AddColumn(newColumn, name);
                              ^~~~~~~~~
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@eguiraud
Copy link
Contributor Author

eguiraud commented May 6, 2020

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

@eguiraud
Copy link
Contributor Author

eguiraud commented May 6, 2020

needs another round of builds after #5556 is merged

@eguiraud
Copy link
Contributor Author

eguiraud commented May 6, 2020

@phsft-bot build please

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add a // FIXME should use make_shared<NewColSlot_t> but ROOT-99999 such that we revert this once the cling bug is fixed.

@eguiraud
Copy link
Contributor Author

eguiraud commented May 6, 2020

Hi Axel, I did it the other way around if it's not a problem (so I won't trigger another round of builds with a rebase): the new ROOT-10754 points to the commits to revert once the underlying problem in cling is fixed.

@phsft-bot
Copy link

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@eguiraud eguiraud merged commit b2033ec into root-project:master May 6, 2020
@eguiraud eguiraud deleted the df_workaround_cling branch May 6, 2020 15:30
@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-05-06T17:20:17.124Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:914 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants