-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[DF] More working around cling+shared_ptr issues #5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should fix errors such as those at https://bit.ly/2W6cZoc : /home/sftnight/build/night/LABEL/ROOT-centos8/SPEC/default/V/master/build/include/ROOT/RDF/RInterface.hxx:2363:25: error: no viable conversion from 'shared_ptr<ROOT::Detail::RDF::RCustomColumn<ROOT::VecOps::RVec<ROOT::VecOps::RVec<unsigned long> > (*)(const ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<float> &, const ROOT::VecOps::RVec<int> &), ROOT::Detail::RDF::CustomColExtraArgs::None>>' to 'const shared_ptr<RDFDetail::RCustomColumnBase>' newCols.AddColumn(newColumn, name); ^~~~~~~~~
|
Starting build on |
|
@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On |
|
Starting build on |
|
needs another round of builds after #5556 is merged |
|
@phsft-bot build please |
|
Starting build on |
Axel-Naumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly add a // FIXME should use make_shared<NewColSlot_t> but ROOT-99999 such that we revert this once the cling bug is fixed.
|
Hi Axel, I did it the other way around if it's not a problem (so I won't trigger another round of builds with a rebase): the new ROOT-10754 points to the commits to revert once the underlying problem in cling is fixed. |
|
Build failed on ROOT-fedora29/python3. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
Should fix errors such as those at https://bit.ly/2W6cZoc :