Skip to content

[cling] Check if we have a bloom filter. #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Axel-Naumann merged 1 commit into from
May 7, 2020
Merged

[cling] Check if we have a bloom filter. #5563

Axel-Naumann merged 1 commit into from
May 7, 2020

Conversation

@vgvassilev
Copy link
Member

@vgvassilev vgvassilev commented May 7, 2020

This fixes an assert in isBloomFilterEmpty which assumes the bloom filter is already built.

This is a fix for PR #4717.

@vgvassilev
[cling] Check if we have a bloom filter.
4e8705d 
This fixes an assert in isBloomFilterEmpty which assumes
the bloom filter is already built.
@vgvassilev vgvassilev requested a review from oshadura May 7, 2020 04:33
@vgvassilev vgvassilev requested a review from Axel-Naumann as a code owner May 7, 2020 04:33
@vgvassilev vgvassilev self-assigned this May 7, 2020
@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@Axel-Naumann Axel-Naumann merged commit 42f24e9 into root-project:master May 7, 2020
@vgvassilev vgvassilev deleted the fix_isempty_assert branch May 7, 2020 07:03
@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-2.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-05-07T09:28:22.928Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:920 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

@oshadura oshadura oshadura approved these changes

Assignees

@vgvassilev vgvassilev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vgvassilev @phsft-bot @Axel-Naumann @oshadura