Skip to content

Adjust asserts. #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vgvassilev merged 1 commit into from
May 7, 2020
Merged

Adjust asserts. #5569

vgvassilev merged 1 commit into from
May 7, 2020

Conversation

@vgvassilev
Copy link
Member

@vgvassilev vgvassilev commented May 7, 2020

This is part of #4717

@vgvassilev vgvassilev requested a review from oshadura May 7, 2020 11:22
@vgvassilev vgvassilev requested a review from Axel-Naumann as a code owner May 7, 2020 11:22
@vgvassilev vgvassilev self-assigned this May 7, 2020
@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

oshadura
oshadura approved these changes May 7, 2020
View reviewed changes
Copy link
Collaborator

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky! :)

@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Build failed on ROOT-fedora29/python3.
Running on root-fedora29-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@vgvassilev vgvassilev merged commit 5d6e0ec into root-project:master May 7, 2020
@vgvassilev vgvassilev deleted the fix_isempty_assert_2 branch May 7, 2020 11:51
@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Build failed on ROOT-debian10-i386/cxx14.
See cdash.
See console output.

@phsft-bot
Copy link

phsft-bot commented May 7, 2020

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Errors:

  • [2020-05-07T11:58:14.509Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:920 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oshadura oshadura oshadura approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

Assignees

@vgvassilev vgvassilev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vgvassilev @phsft-bot @oshadura