Skip to content

[cling] Even when library has no symbols to offer initialize the filter. #5574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 1 commit into from
May 7, 2020
Merged

[cling] Even when library has no symbols to offer initialize the filter. #5574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[cling] Even when library has no symbols to offer initialize the filter. 
This is part of #4717
  • Loading branch information
@vgvassilev
vgvassilev committed May 7, 2020
commit 5a32833f96d0c97fa6800f5eb84554dec5b761e8
3 changes: 2 additions & 1 deletion interpreter/cling/lib/Interpreter/DynamicLibraryManagerSymbol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,8 @@ void Dyld::BuildBloomFilter(LibraryPath* Lib,
}
}

Lib->InitializeBloomFilter(SymbolsCount);

if (!SymbolsCount) {
if (DEBUG > 7)
cling::errs() << "Dyld::BuildBloomFilter: No symbols!\n";
Expand All @@ -569,7 +571,6 @@ void Dyld::BuildBloomFilter(LibraryPath* Lib,
cling::errs() << "Dyld::BuildBloomFilter" << "- " << it << "\n";
}

Lib->InitializeBloomFilter(SymbolsCount);
// Generate BloomFilter
for (const auto &S : symbols) {
if (m_UseHashTable)
Expand Down