-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cling] Allow a Dyld per DynamicLibraryManager. #5637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cling] Allow a Dyld per DynamicLibraryManager. #5637
Conversation
This addresses the rest of the comments of root-project#4717 Patch by Alexander Penev and me.
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. Failing tests:
|
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests:
|
|
Build failed on ROOT-fedora30/cxx14. Failing tests:
|
|
Build failed on ROOT-fedora29/python3. Failing tests:
|
|
@phsft-bot build |
|
Starting build on |
|
Build failed on mac1015/cxx17. |
Axel-Naumann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume most of the changes are just moving code around - but it's impossible to see in github :-( So assuming this there is just the question of Dyld's lifetime vs that of DynamicLibraryManager: if we can tie the two then there's no need for checking whether Dyld has been initialized or not; it's guaranteed by the constructor. Would that be an option?
|
Thanks for explaining! |
|
@phsft-bot build! |
|
Starting build on |
This addresses the rest of the comments of #4717
Patch by Alexander Penev (@alexander-penev) and me.