Skip to content

Conversation

@vgvassilev
Copy link
Member

@vgvassilev vgvassilev commented May 18, 2020

This addresses the rest of the comments of #4717

Patch by Alexander Penev (@alexander-penev) and me.

This addresses the rest of the comments of root-project#4717

Patch by Alexander Penev and me.
@vgvassilev vgvassilev requested a review from Axel-Naumann as a code owner May 18, 2020 05:18
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@vgvassilev
Copy link
Member Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on mac1015/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See cdash.
See console output.

Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume most of the changes are just moving code around - but it's impossible to see in github :-( So assuming this there is just the question of Dyld's lifetime vs that of DynamicLibraryManager: if we can tie the two then there's no need for checking whether Dyld has been initialized or not; it's guaranteed by the constructor. Would that be an option?

@Axel-Naumann
Copy link
Member

Thanks for explaining!

@vgvassilev
Copy link
Member Author

@phsft-bot build!

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@vgvassilev vgvassilev merged commit 63df84c into root-project:master May 25, 2020
@vgvassilev vgvassilev deleted the dyld_remove_statics branch May 25, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants