Skip to content

C++17 fixes #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidlt wants to merge 7 commits into from
Closed

C++17 fixes #591

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b490f2e
Fix check for std::apply (R__HAS_STD_APPLY)
davidlt May 26, 2017
f692ada
Set __cplusplus to 201703L for C++1z (C++17)
davidlt May 26, 2017
35469f4
Don't provide std::__ROOT::apply if R__HAS_STD_APPLY is defined
davidlt May 26, 2017
da6e821
Add missing <functional> header
davidlt May 26, 2017
9fc549c
Fix std::string_view usage if compiled in C++17 mode
davidlt May 26, 2017
be8dddd
Apply git clang-format suggested changes
davidlt May 26, 2017
0276049
Provide null-terminated C strings
davidlt May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Provide null-terminated C strings 
std::string_view::data() does not guarantee null-terminated string.

Signed-off-by: David Abdurachmanov <[email protected]>
  • Loading branch information
@davidlt
davidlt committed May 26, 2017
commit 0276049f39bca378779da0d3d0d4c0e5ed15ddb6
4 changes: 2 additions & 2 deletions io/io/v7/src/TFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class TV6Storage: public ROOT::Experimental::Internal::TFileStorageInterface {
}

void WriteMemoryWithType(std::string_view name, const void* address, TClass* cl) final {
fOldFile->WriteObjectAny(address, cl, name.data());
fOldFile->WriteObjectAny(address, cl, std::string(name.data(), name.size()).c_str());
}
};
}
Expand Down Expand Up @@ -191,7 +191,7 @@ std::string ROOT::Experimental::TFile::SetCacheDir(std::string_view path) {
std::lock_guard<std::mutex> lock(GetCacheDirMutex());

std::string ret = ::TFile::GetCacheFileDir();
::TFile::SetCacheFileDir(path.data());
::TFile::SetCacheFileDir(std::string(path.data(), path.size()).c_str());
return ret;
}

Expand Down