Add support for LZ4 in classic build #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/make to catch up)" This reverts commit 4b0220b. Re-enable LZ4 builds for work on configure/make build.
|
Can one of the admins verify this patch? |
bbockelm
force-pushed
the
master-lz4-classic
branch
from
bf70bf3 to
d64cdc7
Compare
Member
|
Can you extend roottest/root/io/compression and roottest/root/io/filemerger to include lz4? thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for LZ4 in the "classic" configure/Makefile build, adding near-parity to the
cmake-based build.The exception is
win32--core/lz4/Module.mkwill need to be heavily tackled by someone with a Windows background (I do not have access to a Windows-based host).@pcanal - note that this reverts the commit disabling LZ4 for the
cmake-based build.