Skip to content

Set cling optimization level to 3 and turn off pointer checks #6038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LukasBreitwieser wants to merge 1 commit into from
Closed

Set cling optimization level to 3 and turn off pointer checks #6038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/metacling/src/TCling.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,6 +1573,10 @@ TCling::TCling(const char *name, const char *title, const char* const argv[])
fClingCallbacks->SetAutoParsingSuspended(fIsAutoParsingSuspended);
fInterpreter->setCallbacks(std::move(clingCallbacks));

// force optlevel 3
fInterpreter->getCI()->getCodeGenOpts().OptimizationLevel = 3;
fInterpreter->setDefaultOptLevel(3);

if (!fromRootCling) {
cling::DynamicLibraryManager& DLM = *fInterpreter->getDynamicLibraryManager();
// Make sure cling looks into ROOT's libdir, even if not part of LD_LIBRARY_PATH
Expand Down
3 changes: 3 additions & 0 deletions interpreter/cling/lib/Interpreter/BackendPasses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ void BackendPasses::CreatePasses(llvm::Module& M, int OptLevel)
// Inlining = CGOpts.NoInlining;
}

// force normal inlining (as above says: NoInlining is kills)
const_cast<CodeGenOptions&>(m_CGOpts).setInlining(CodeGenOptions::NormalInlining);

llvm::PassManagerBuilder PMBuilder;
PMBuilder.OptLevel = OptLevel;
PMBuilder.SizeLevel = m_CGOpts.OptimizeSize;
Expand Down
2 changes: 1 addition & 1 deletion interpreter/cling/lib/Interpreter/CIFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,7 +1589,7 @@ static void stringifyPreprocSetting(PreprocessorOptions& PPOpts,
// FIXME: We have a bug when we switch to -O2, for some cases it takes
// several minutes to optimize, while the same code compiled by clang -O2
// takes only a few seconds.
CGOpts.OptimizationLevel = 0;
CGOpts.OptimizationLevel = 3;
// Taken from a -O2 run of clang:
CGOpts.DiscardValueNames = 1;
CGOpts.OmitLeafFramePointer = 1;
Expand Down
2 changes: 1 addition & 1 deletion interpreter/cling/lib/Interpreter/IncrementalParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ namespace cling {
std::vector<ASTTPtr_t> ASTTransformers;
ASTTransformers.emplace_back(new AutoSynthesizer(TheSema));
ASTTransformers.emplace_back(new EvaluateTSynthesizer(TheSema));
if (hasCodeGenerator() && !m_Interpreter->getOptions().NoRuntime) {
if (0 && hasCodeGenerator() && !m_Interpreter->getOptions().NoRuntime) {
Copy link
Contributor Author

@LukasBreitwieser LukasBreitwieser Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which approach do you recommend to turn off pointer checks?

// Don't protect against crashes if we cannot run anything.
// cling might also be in a PCH-generation mode; don't inject our Sema
// pointer into the PCH.
Expand Down