Skip to content

Conversation

@reikdas
Copy link
Contributor

@reikdas reikdas commented Nov 3, 2020

It seems independent Cling builds have been broken on Windows for a while (or am making an error when setting up the build in Cling's Github Actions CI?)

Looking at Cling commits - https://github.com/root-project/cling/commits/master it looks like Cling's appveyor hasn't even triggered in a long time, so it is difficult to say when was the last time that an independent Cling built worked on Windows.

I made some attempt to fix it via - db80e8c but that is clearly not enough.

One can look at the build error logs on Windows in the corresponding Github Action workflow - https://github.com/reikdas/cling-1/runs/1348031890?check_suite_focus=true

@vgvassilev @bellenot Do you have any idea what could be going wrong?

If Cling can be built successfully on Windows, we can merge this in :D

@reikdas reikdas requested a review from vgvassilev November 3, 2020 16:45
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2020-11-03T16:46:28.741Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1002 (message):

@phsft-bot
Copy link

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2020-11-03T16:46:46.163Z] CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  • [2020-11-03T16:46:46.686Z] CMake Error at /build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2020-11-03T17:10:00.474Z] LINK : fatal error LNK1181: cannot open input file 'cladPlugin.lib' [C:\build\workspace\root-pullrequests-build\build\core\metacling\src\Cling.vcxproj]

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@reikdas
Copy link
Contributor Author

reikdas commented Nov 4, 2020

Since we removed the Ninja build on Windows, the issue we need to solve right now is how to fix the failing Cling tests on Windows - https://github.com/reikdas/cling-1/runs/1353774432?check_suite_focus=true#step:7:9589. I tried to fix it via 21ffc04 but that did not work :(

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@guitargeek
Copy link
Contributor

We have Windows build on the CI every time now, dunno why this PR is needed! In case I'm wrong, feel free to reopen it 🙂

@guitargeek guitargeek closed this Jun 3, 2024
@pcanal
Copy link
Member

pcanal commented Jun 15, 2024

This is about the Cling specific CI. @vgvassilev do you want to review this PR or to close it?

@pcanal pcanal reopened this Jun 15, 2024
@vgvassilev
Copy link
Member

This is not a bad change. It needs some more work but I think @reikdas has moved on and I do not have the bandwidth to do it...

@ferdymercury ferdymercury requested a review from devajithvs May 30, 2025 07:04
@ferdymercury ferdymercury requested a review from dpiparo August 29, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants