-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Cling] Add Windows CI to Github Actions #6750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Starting build on |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on ROOT-fedora31/noimt. Errors:
|
|
Build failed on windows10/cxx14. Errors:
|
motivated by the need to fix build on Windows
since cat is not available on Windows
0fcb8ae to
be235cb
Compare
|
Starting build on |
|
Since we removed the Ninja build on Windows, the issue we need to solve right now is how to fix the failing Cling tests on Windows - https://github.com/reikdas/cling-1/runs/1353774432?check_suite_focus=true#step:7:9589. I tried to fix it via 21ffc04 but that did not work :( |
|
Build failed on windows10/cxx14. Failing tests: |
|
We have Windows build on the CI every time now, dunno why this PR is needed! In case I'm wrong, feel free to reopen it 🙂 |
|
This is about the Cling specific CI. @vgvassilev do you want to review this PR or to close it? |
|
This is not a bad change. It needs some more work but I think @reikdas has moved on and I do not have the bandwidth to do it... |
It seems independent Cling builds have been broken on Windows for a while (or am making an error when setting up the build in Cling's Github Actions CI?)
Looking at Cling commits - https://github.com/root-project/cling/commits/master it looks like Cling's appveyor hasn't even triggered in a long time, so it is difficult to say when was the last time that an independent Cling built worked on Windows.
I made some attempt to fix it via - db80e8c but that is clearly not enough.
One can look at the build error logs on Windows in the corresponding Github Action workflow - https://github.com/reikdas/cling-1/runs/1348031890?check_suite_focus=true
@vgvassilev @bellenot Do you have any idea what could be going wrong?
If Cling can be built successfully on Windows, we can merge this in :D