-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Revert "Work around vtable index issue due to base class definition b… #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Work around vtable index issue due to base class definition b… #682
Conversation
…eing replaced by later PCM." This reverts commit fc1cb80. And brings that file back to the original clang version.
|
Starting build on |
|
Build failed on centos7/gcc49. Warnings:
Failing tests: |
|
Build failed on ubuntu14/native. Warnings:
Failing tests: |
|
Build failed on slc6/gcc49. Warnings:
Failing tests: |
|
Build failed on mac1012/native. Warnings:
Failing tests: |
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on slc6/gcc49. Warnings:
Failing tests: |
|
Build failed on ubuntu14/native. Warnings:
Failing tests: |
|
Build failed on centos7/gcc49. Warnings:
Failing tests: |
|
Build failed on mac1012/native. Warnings:
Failing tests: |
|
Build failed on slc6/gcc62. Warnings:
Failing tests: |
|
@phsft-bot build! @Axel-Naumann shall we merge that in? |
|
Starting build on |
|
Build failed on slc6/gcc62. Warnings:
Failing tests: |
|
@vgvassilev I'd prefer to first get a status update from say CMS and LHCb: they need to have a green build now, such that we can confirm that this reversed patch doesn't break them. I think this one was (also) visible in LHCb. Could you contact Marco and DavidA to assert that they get a green build with the master? |
|
@davidlt, could we validate if with this PR CMSSW is still fine? @Axel-Naumann I do not have Marco's git handle. |
|
@phsft-bot build! |
|
Starting build on |
…eing replaced by later PCM."
This reverts commit fc1cb80.
And brings that file back to the original clang version.