Skip to content

Disable unnecessary rebuilds on git changes #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 2 commits into from
Jul 26, 2017
Merged

Disable unnecessary rebuilds on git changes #813

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db2e772
Disable rebuilding unnecessarily when git HEAD changes.
Teemperor Jul 26, 2017
3bd83ce
Fix that LLVM currently rebuilds unnecessarily when git HEAD changes.
Teemperor Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable rebuilding unnecessarily when git HEAD changes. 
Currently LLVM LTO and other parts depend on the git HEAD file
because they pull in the current git revision (and should update
when the git revision changes). This is causing some unnecessary
rebuilding everytime someone is touching his git HEAD file.

This commit is disabling this in future LLVM versions by setting
the appropriate flag in LLVM to OFF (doesn't do a lot by now
as we first need to get this revision in the ROOT llvm version
https://reviews.llvm.org/D35377).
  • Loading branch information
@Teemperor
Teemperor committed Jul 26, 2017
commit db2e772abbc576b4642c3ee9a538ad51ce3565a0
3 changes: 3 additions & 0 deletions interpreter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ set(CLANG_ENABLE_FORMAT OFF CACHE BOOL "")
#---Remove the inherited include_directories()
set_directory_properties(PROPERTIES INCLUDE_DIRECTORIES "")

#---Disable VCS writing to prevent that we always have to rebuild when someone touched the git HEAD
set(LLVM_APPEND_VC_REV OFF CACHE BOOL "Disabled LLVM revision dependency" FORCE)

#---Add the sub-directory excluding all the targets from all-----------------------------------------
if(CMAKE_GENERATOR MATCHES "Xcode")
add_subdirectory(llvm/src)
Expand Down