-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[RF] Make it possible to store global observables in RooAbsData and consider these global observables in RooAbsPdf::fitTo
#8878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
guitargeek
merged 9 commits into
root-project:master
from
guitargeek:GlobalObservables_2
Sep 14, 2021
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f234571
[RF] New `RooAbsPdf::minimizeNLL()` for minimization outside of fitTo
guitargeek 7394e0a
[RF] Allow for storing global observable values in RooAbsData
guitargeek 2a21c38
[RF] Add `GlobalObservables` cmd arg to `RooDataSet/Hist` constructors
guitargeek 7b915d7
[RF] Consider global observables stored in dataset in fits
guitargeek 5052490
[RF] Implement `RooConstraintSum::setData()`
guitargeek e2a6254
[RF] New `GlobalObservablesSource` cmd arg for `RooAbsPdf::createNLL`
guitargeek 3337cf6
[RF] Redirect global observables to dataset also outside of constraints
guitargeek 8fac07b
[RF] New testGlobalObservables to validate global observables in data
guitargeek fa0166b
[RelNotes] Write about storing global observables in RooFit datasets
guitargeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
[RelNotes] Write about storing global observables in RooFit datasets
- Loading branch information
commit fa0166b99a3ef1e5cb86fcd262cbb5126ffe1111
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually great info, which shouldn't be buried in release notes only. This belongs into the data class documentations as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point 👍