[cxxmodules] Added missing PushTransactionRAII to GetMangledName #913
Conversation
rootcling with modules can reach this method when running with C++ modules and then starts deserializing decls without a transaction. This adds the missing PUshTransactionRAII.
|
Starting build on |
|
Build failed on centos7/gcc49. |
|
Build failed on slc6/gcc62. |
|
Build failed on slc6/gcc49. |
|
Build failed on mac1012/native. |
|
Build failed on ubuntu14/native. |
Axel-Naumann
left a comment
Axel-Naumann
left a comment
There was a problem hiding this comment.
LGTM! Do you need the review by @vgvassilev? Else I think this can go in as is.
|
@phsft-bot build I think that can go in as-is. But Jenkins seems to have died compiling this, so let's see give it another chance. |
|
Starting build on |
|
Build failed on ubuntu14/native. |
|
Build failed on centos7/gcc49. |
|
Build failed on slc6/gcc62. |
|
Build failed on mac1012/native. |
|
Build failed on slc6/gcc49. |
|
@phsft-bot build |
|
Starting build on |
5 participants
rootcling with modules can reach this method when running with
C++ modules and then starts deserializing decls without a
transaction. This adds the missing PUshTransactionRAII.