Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
67d2d49
Remove never used enum (TRef::kNotComputed)
pcanal Aug 29, 2017
f7b63a2
Remove enum TClonesArray::kNoSplit not used since 2.26 (circa 2001)
pcanal Aug 29, 2017
e9c82a3
Update release notes
pcanal Aug 29, 2017
9a9d54f
Mark status bits as 'enum EStatusBits' in core, i/o, tree and hist.
pcanal Aug 29, 2017
4b8053e
Remove never used enum constant TLink::kObjIsParent
pcanal Aug 29, 2017
18c9cb5
Change value of TBranchObject::kWarn. Reset it upon reading.
pcanal Aug 29, 2017
8084146
Change value of TLeafObject::kWarn. Reset it upon reading.
pcanal Aug 29, 2017
20d96bb
Change value of TApplicationRemote::kCollecting.
pcanal Aug 29, 2017
1bc4ff7
Remove information duplication
pcanal Aug 29, 2017
87a10fc
Mark TObject::kObjInCanvas as deprecated
pcanal Aug 29, 2017
71f2c55
Add comments on status bits that are not available to TObject (even-t…
pcanal Aug 29, 2017
e2bf336
Update value of TClonesArray::kForgetBits.
pcanal Aug 30, 2017
67609c6
Introduce EStatusBitsDupExceptions in TStreamerElement and TVirtualSt…
pcanal Aug 30, 2017
f2ebec4
Introduce TStatusBitsChecker to avoid Status Bits overlap.
pcanal Aug 31, 2017
127c729
In ConvertToBit replace log2,nearbyint with std::frexp.
pcanal Aug 31, 2017
ae8a0ce
White spaces [NFC]
pcanal Aug 31, 2017
f2da26f
Typo [NFC]
pcanal Sep 1, 2017
3f043a6
Add TSystem::LoadAllLibs
pcanal Sep 1, 2017
28b43f6
Change value of TProofServ::kHighMemory and TVirtualProofPlayer::kIsS…
pcanal Sep 1, 2017
3fa653f
Add TStatusBitsChecker.cxx gtest
pcanal Sep 1, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change value of TProofServ::kHighMemory and TVirtualProofPlayer::kIsS…
…ubmerger.

Error in <TStatusBitsChecker>: In TProofPlayer class hierarchy, there are duplicates bits:
Error in <TStatusBitsChecker>:    Bit  16 used in TProofPlayer as kIsProcessing
Error in <TStatusBitsChecker>:    Bit  16 used in TVirtualProofPlayer as kIsSubmerger

Error in <TStatusBitsChecker>: In TProofServ class hierarchy, there are duplicates bits:
Error in <TStatusBitsChecker>:    Bit  16 used in TProofServ as kHighMemory
Error in <TStatusBitsChecker>:    Bit  16 used in TApplication as kDefaultApplication
  • Loading branch information
pcanal committed Sep 1, 2017
commit 28b43f64bdf0dbd403efd4ae18ff395daf2ca0cc
2 changes: 1 addition & 1 deletion proof/proof/inc/TProofServ.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ friend class TProofServLite;
friend class TXProofServ;

public:
enum EStatusBits { kHighMemory = BIT(16) };
enum EStatusBits { kHighMemory = BIT(17) };
enum EQueryAction { kQueryOK, kQueryModify, kQueryStop, kQueryEnqueued };

private:
Expand Down
2 changes: 1 addition & 1 deletion proof/proof/inc/TVirtualProofPlayer.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class TSelector;
class TVirtualProofPlayer : public TObject, public TQObject {

public:
enum EStatusBits { kIsSubmerger = BIT(16) };
enum EStatusBits { kIsSubmerger = BIT(14) };
// TDSet status bits
enum EExitStatus { kFinished, kStopped, kAborted };

Expand Down