[cxxmodules] Start generating modules in rootcling. #930

Teemperor · 2017-09-04T07:56:03Z

See the specific commits for changes.

phsft-bot · 2017-09-04T07:56:36Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-09-04T08:06:06Z

Build failed on ubuntu14/native.
See console output.

Errors:

/mnt/vdb/lsf/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:2366:42: error: ‘const string’ has no member named ‘str’
/mnt/vdb/lsf/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:4287:9: error: ‘argvCompile’ was not declared in this scope

phsft-bot · 2017-09-04T08:06:57Z

Build failed on centos7/gcc49.
See console output.

Errors:

/mnt/build/jenkins/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:2366:42: error: ‘const string’ has no member named ‘str’
/mnt/build/jenkins/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:4287:9: error: ‘argvCompile’ was not declared in this scope

phsft-bot · 2017-09-04T08:07:51Z

Build failed on slc6/gcc49.
See console output.

Errors:

/mnt/build/jenkins/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:2366:42: error: ‘const string’ has no member named ‘str’
/mnt/build/jenkins/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:4287:9: error: ‘argvCompile’ was not declared in this scope

phsft-bot · 2017-09-04T08:08:39Z

Build failed on slc6/gcc62.
See console output.

Errors:

/mnt/build/jenkins/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:2366:42: error: ‘const string {aka const class std::__cxx11::basic_string<char>}’ has no member named ‘str’
/mnt/build/jenkins/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:4287:9: error: ‘argvCompile’ was not declared in this scope

phsft-bot · 2017-09-04T08:09:48Z

Build failed on mac1012/native.
See console output.

Errors:

/Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:2366:42: error: no member named 'str' in 'std::__1::basic_string<char>'
/Volumes/HDD2/ec/build/workspace/root-pullrequests-build/root/core/dictgen/src/rootcling_impl.cxx:4287:9: error: use of undeclared identifier 'argvCompile'

phsft-bot · 2017-09-04T09:36:35Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-09-04T09:36:56Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Teemperor · 2017-09-04T09:37:07Z

@phsft-bot build

phsft-bot · 2017-09-04T09:37:24Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-09-04T10:40:16Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T11:01:53Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T11:08:55Z

Build failed on mac1012/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T11:24:46Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T11:35:55Z

Build failed on centos7/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

Axel-Naumann

Very nice progress!

Axel-Naumann · 2017-09-04T12:49:17Z

core/dictgen/src/rootcling_impl.cxx

+         auto &headerList = module->Headers[i];
+         // Include all headers from this module.
+         for (const clang::Module::Header &moduleHeader : headerList) {
+            // FIXME: Shall we include the absolute path here?


It's much more performant to first generate the string containing all #includes and then declare() that.

Fixed, thanks!

Axel-Naumann · 2017-09-04T12:54:01Z

core/dictgen/src/rootcling_impl.cxx

+      for (clang::Module *subModule : M->submodules())
+         modules.insert(subModule);
+   }
+   // Now we include all header files from the previously collected modules.


Should the includes be ordered leaf-modules to module, i.e. the inverse? In case any of the headers has a missing #include?

I would like to do this the way clang is doing it which is by marking each header as a submodule and then let the visibility settings inside the module enforce this (e.g., the order doesn't matter, but clang ensures that each header first needs to import the submodules of the used headers, and if it doesn't it can't see the specific decls from this header even if they were parsed before and errors out with a nice error message that shows what include is missing).

This will either happen when we get the GenerateModuleAction from clang (which would still be the best solution) or until I get around and check out how to do this from rootcling.
I'll add a FIXME: that this is documented.

Axel-Naumann · 2017-09-04T12:56:24Z

core/dictgen/src/rootcling_impl.cxx

-   if (StringRef(moduleName).endswith("_rdict.pcm")) {
-      auto lengthWithoutSuffix = moduleName.size() - strlen("_rdict.pcm");
-      moduleName = moduleName.substr(0, lengthWithoutSuffix) + ".so";
+   while (!LinkdefPath.empty()) {


I guess this warrants at least a comment. I also think that it's generally wrong, as it seems to e.g. add my home directory as include path for every ROOT build that's within my home directory structure.

Was a workaround we need for finding the modulemaps. I move this to its own PR and repropose when we see the hit the issue in the master branch.

Axel-Naumann · 2017-09-04T12:57:32Z

core/dictgen/src/rootcling_impl.cxx

   }

+   if (sharedLibraryPathName.empty()) {
+      sharedLibraryPathName = dictpathname;


This breaks the requirement (of the following if) that the library path name must be stated for the multidict case. I'm also not sure why this assignment is valid in the general case. E.g. IIRC CMS is using the same dictionary name for basically all its libraries.

Hmm, this is from the master branch, I just moved it up because I needed to replicate the TModuleGenerator logic (due to the cyclic dependency that I explained in the comment below):

root/core/dictgen/src/rootcling_impl.cxx

Line 4424 in 94a28b7

if (sharedLibraryPathName.empty()) {

Axel-Naumann · 2017-09-04T13:00:25Z

interpreter/cling/include/cling/Interpreter/InvocationOptions.h

    unsigned Verbose : 1;
+    unsigned CxxModules : 1;
+    // The output path of any C++ PCMs we're building on demand.
+    std::string CachePath;


Can you throw in what you're caching, I guess ModuleCachePath?

Fixed, thanks!

Axel-Naumann · 2017-09-04T13:03:54Z

interpreter/cling/lib/Interpreter/CIFactory.cpp

+
+    // If user has enabled C++ modules we add some special module flags to the
+    // compiler invocation. C++ modules don't make any sense when we are anyway
+    // supposed to Lex the input, so let's not do it in the OnlyLex mode.


Isn't OnlyLex the tab completion flag? In that case modules would help, right?

Just to document what we discussed: It's only used by the LinkdefReader from what I can see. And here we can't use modules (as the LinkdefReader can't parse headers because __CINT__is defined when we parse Linkdefs, and this define breaks user code).

But this check was indeed only back when we used the global ROOT_MODULES setting. so I think this check can indeed can go away so one can use this setting in cling.

Axel-Naumann · 2017-09-04T13:06:29Z

interpreter/cling/lib/Interpreter/CIFactory.cpp

+      // Code below from the (private) code in the GenerateModuleAction class.
+      llvm::SmallVector<char, 256> Output;
+      llvm::sys::path::append(Output, COpts.CachePath,
+                              COpts.ModuleName + ".pcm");


Shouldn't we mark these ROOT-specific PCMs by giving them a more distinctive name?

Axel-Naumann · 2017-09-04T13:07:22Z

interpreter/cling/lib/Interpreter/CIFactory.cpp

+    // With C++ modules, we now attach the consumers that will handle the
+    // generation of the PCM file itself.
+    if (COpts.CxxModules) {
+      // Code below from the (private) code in the GenerateModuleAction class.


Would the use of WriteAST() simplify things?

I think you were on vacation when the discussion about this happened, but to sum it up: Modules can't just be written via WriteAST(). They need a listener that we attach here that keeps track on things like what other module we load and in what order. This code wraps the WriteAST, the creation/attaching of the listener, etc. in the way with the least amount of copy pasted code from clang.

In the future we can either drop this code once I get rootcling into a form where we can reuse the whole GenerateModuleAction from clang or we make it public that we can easily reuse it. But first I want to see how far the rootcling refactor idea allows us to go :)

Axel-Naumann · 2017-09-04T13:08:08Z

interpreter/cling/lib/Interpreter/CIFactory.cpp

+          CI->getFrontendOpts().ModuleFileExtensions,
+          /*AllowASTWithErrors=*/false,
+          /*IncludeTimestamps=*/
+          +CI->getFrontendOpts().BuildingImplicitModule));


That leading + is ... weird.

Yeah, that's the way it's in the original source code, I'll drop it and also remove it upstream.

Actually, this seems to had a purpose. Back to this way.

I wanted to ask Richard about the semantics of this but forgot...

Axel-Naumann · 2017-09-04T13:09:58Z

interpreter/cling/lib/Interpreter/InvocationOptions.cpp

      case options::OPT_nostdincxx: NoCXXInc = true; break;
      case options::OPT_v: Verbose = true; break;
+      case options::OPT_fmodules: CxxModules = true; break;
+      case options::OPT_fmodule_name_EQ:


Can you add // explicit fall-through here?

We are in LLVM here, so we can even use the explicit LLVM fallthrough :). Fixed, thanks!

vgvassilev · 2017-09-04T17:56:59Z

@phsft-bot build with flags -Druntime_cxxmodules=On

phsft-bot · 2017-09-04T17:57:13Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On
How to customize builds

phsft-bot · 2017-09-04T18:29:22Z

Build failed on centos7/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T18:34:23Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T18:37:59Z

Build failed on mac1012/native.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T18:42:21Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-04T18:50:49Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.roottest.root.meta.ROOT-7462.roottest_root_meta_ROOT_7462_make

phsft-bot · 2017-09-14T08:18:20Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

phsft-bot · 2017-09-14T08:49:18Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

This makes it easier for cling to check if -fmodules and/or -fmodule-name is passed so that we can act on these flags in the CIFactory.

This patch adds support for writing out modules to the CIFactory. If the user has passed -fmodule-name and -fmodules, we start extending the CI instance with support for C++ modules and also optionally setup AST consumers for writing out modules files alongside the interpreter.

This patch enables C++ modules support in rootcling. We now add the correct cling flags that will trigger the modules setup in the CIFactory. We also start reusing the normal clang code for generating modules as far as possible. For this we had to hack around a few bugs in ROOT like the fact that we actually never call many of the interpreter destructors (or if we do, we don't call the in a consistent way between rootcling and rootcling_stage1), mainly manually calling the end of the translation unit.

phsft-bot · 2017-09-14T09:52:52Z

Build failed on slc6/gcc49.
See console output.

Errors:

ERROR: Timeout after 10 minutes
ERROR: Error fetching remote repo 'origin'
stderr: error: RPC failed; result=18, HTTP code = 200
error: fetch-pack died of signal 15
ERROR: Error fetching remote repo 'origin'

Teemperor · 2017-09-14T10:10:39Z

@phsft-bot build with flags -Druntime_cxxmodules=On

phsft-bot · 2017-09-14T10:10:46Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On
How to customize builds

phsft-bot · 2017-09-14T10:15:59Z

Build failed on slc6/gcc62.
See console output.

Errors:

/usr/include/wctype.h:74:3: error: redefinition of enumerator '__ISwupper'
/usr/include/wctype.h:75:3: error: redefinition of enumerator '__ISwlower'
/usr/include/wctype.h:76:3: error: redefinition of enumerator '__ISwalpha'
/usr/include/wctype.h:77:3: error: redefinition of enumerator '__ISwdigit'
/usr/include/wctype.h:78:3: error: redefinition of enumerator '__ISwxdigit'
/usr/include/wctype.h:79:3: error: redefinition of enumerator '__ISwspace'
/usr/include/wctype.h:80:3: error: redefinition of enumerator '__ISwprint'
/usr/include/wctype.h:81:3: error: redefinition of enumerator '__ISwgraph'
/usr/include/wctype.h:82:3: error: redefinition of enumerator '__ISwblank'
/usr/include/wctype.h:83:3: error: redefinition of enumerator '__ISwcntrl'

And 10 more

Warnings:

/mnt/build/jenkins/workspace/root-pullrequests-build/build/include/TSystem.h:359:62: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
/mnt/build/jenkins/workspace/root-pullrequests-build/build/include/TSystem.h:360:51: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
/mnt/build/jenkins/workspace/root-pullrequests-build/build/include/TUnixSystem.h:56:62: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
/mnt/build/jenkins/workspace/root-pullrequests-build/build/include/TUnixSystem.h:97:56: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:

And 11 more

phsft-bot · 2017-09-14T10:16:14Z

Build failed on slc6/gcc49.
See console output.

Errors:

/usr/include/wctype.h:74:3: error: redefinition of enumerator '__ISwupper'
/usr/include/wctype.h:75:3: error: redefinition of enumerator '__ISwlower'
/usr/include/wctype.h:76:3: error: redefinition of enumerator '__ISwalpha'
/usr/include/wctype.h:77:3: error: redefinition of enumerator '__ISwdigit'
/usr/include/wctype.h:78:3: error: redefinition of enumerator '__ISwxdigit'
/usr/include/wctype.h:79:3: error: redefinition of enumerator '__ISwspace'
/usr/include/wctype.h:80:3: error: redefinition of enumerator '__ISwprint'
/usr/include/wctype.h:81:3: error: redefinition of enumerator '__ISwgraph'
/usr/include/wctype.h:82:3: error: redefinition of enumerator '__ISwblank'
/usr/include/wctype.h:83:3: error: redefinition of enumerator '__ISwcntrl'

And 10 more

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module forward_listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:

And 7 more

phsft-bot · 2017-09-14T10:19:18Z

Build failed on centos7/gcc49.
See console output.

Errors:

/usr/include/wctype.h:73:3: error: redefinition of enumerator '__ISwupper'
/usr/include/wctype.h:74:3: error: redefinition of enumerator '__ISwlower'
/usr/include/wctype.h:75:3: error: redefinition of enumerator '__ISwalpha'
/usr/include/wctype.h:76:3: error: redefinition of enumerator '__ISwdigit'
/usr/include/wctype.h:77:3: error: redefinition of enumerator '__ISwxdigit'
/usr/include/wctype.h:78:3: error: redefinition of enumerator '__ISwspace'
/usr/include/wctype.h:79:3: error: redefinition of enumerator '__ISwprint'
/usr/include/wctype.h:80:3: error: redefinition of enumerator '__ISwgraph'
/usr/include/wctype.h:81:3: error: redefinition of enumerator '__ISwblank'
/usr/include/wctype.h:82:3: error: redefinition of enumerator '__ISwcntrl'

And 10 more

Warnings:

Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module forward_listDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_multisetDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:

And 7 more

phsft-bot · 2017-09-14T10:22:51Z

Build failed on mac1012/native.
See console output.

Errors:

/usr/include/sys/_posix_availability.h:29:3: error: "Never use <sys/_posix_availability.h> directly. Use <sys/cdefs.h> instead."
/usr/include/sys/_types/_intptr_t.h:30:9: error: declaration of '__darwin_intptr_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/sys/_types/_size_t.h:30:9: error: declaration of '__darwin_size_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/sys/_types/_ct_rune_t.h:31:9: error: declaration of '__darwin_ct_rune_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/sys/_types/_rune_t.h:30:9: error: declaration of '__darwin_rune_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/sys/_types/_wint_t.h:31:9: error: declaration of '__darwin_wint_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/mach/i386/_structs.h:321:2: error: declaration of '__uint8_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/sys/_pthread/_pthread_attr_t.h:30:9: error: missing '#include <sys/_pthread/_pthread_types.h>'; declaration of '__darwin_pthread_attr_t' must be imported from module 'Darwin.sys._pthread._pthread_types' before it is required
/usr/include/sys/_types/_sigaltstack.h:39:2: error: declaration of '__darwin_size_t' must be imported from module 'Darwin.machine._types' before it is required
/usr/include/sys/_types/_ucontext.h:37:2: error: missing '#include <sys/_types.h>'; declaration of '__darwin_sigset_t' must be imported from module 'Darwin.POSIX.sys.types' before it is required

And 10 more

phsft-bot · 2017-09-14T10:42:32Z

Build failed on ubuntu14/native.
See console output.

Errors:

/usr/include/wctype.h:73:3: error: redefinition of enumerator '__ISwupper'
/usr/include/wctype.h:74:3: error: redefinition of enumerator '__ISwlower'
/usr/include/wctype.h:75:3: error: redefinition of enumerator '__ISwalpha'
/usr/include/wctype.h:76:3: error: redefinition of enumerator '__ISwdigit'
/usr/include/wctype.h:77:3: error: redefinition of enumerator '__ISwxdigit'
/usr/include/wctype.h:78:3: error: redefinition of enumerator '__ISwspace'
/usr/include/wctype.h:79:3: error: redefinition of enumerator '__ISwprint'
/usr/include/wctype.h:80:3: error: redefinition of enumerator '__ISwgraph'
/usr/include/wctype.h:81:3: error: redefinition of enumerator '__ISwblank'
/usr/include/wctype.h:82:3: error: redefinition of enumerator '__ISwcntrl'

And 10 more

Warnings:

/mnt/vdb/lsf/workspace/root-pullrequests-build/build/include/TSystem.h:359:62: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
/mnt/vdb/lsf/workspace/root-pullrequests-build/build/include/TSystem.h:360:51: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
/mnt/vdb/lsf/workspace/root-pullrequests-build/build/include/TUnixSystem.h:56:62: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
/mnt/vdb/lsf/workspace/root-pullrequests-build/build/include/TUnixSystem.h:97:56: warning: ambiguous use of internal linkage declaration 'ignore' defined in multiple modules [-Wmodules-ambiguous-internal-linkage]
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module unordered_setDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:
Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:

And 11 more

Teemperor · 2017-09-14T11:20:47Z

Ok, the warnings are for the obvious modulemap mismatches we have and the errors are due to the yet missing VFS mapping. Can we get this in that I can make the follow up PRs?

Teemperor added the do not merge label Sep 4, 2017

Teemperor requested review from Axel-Naumann, dpiparo and vgvassilev September 4, 2017 07:56

Teemperor requested a review from pcanal as a code owner September 4, 2017 07:56

Teemperor force-pushed the EnableModulesCIFactory branch 2 times, most recently from 3685e10 to 3164d9c Compare September 4, 2017 09:36

Axel-Naumann requested changes Sep 4, 2017

View reviewed changes

Teemperor mentioned this pull request Sep 14, 2017

[llvm] Fix InvalidTagDeclDefinition in Multiplexer #991

Merged

Teemperor force-pushed the EnableModulesCIFactory branch from e7117a2 to f89d5f1 Compare September 14, 2017 08:49

Teemperor added 3 commits September 14, 2017 10:50

[cxxmodules] Extended InvocationOptions with C++ modules flags.

9d97589

This makes it easier for cling to check if -fmodules and/or -fmodule-name is passed so that we can act on these flags in the CIFactory.

vgvassilev merged commit 97647c1 into root-project:master Sep 14, 2017

Teemperor deleted the EnableModulesCIFactory branch December 19, 2017 08:39

This was referenced Sep 3, 2021

[RF] Make it possible to store global observables in RooAbsData and consider these global observables in RooAbsPdf::fitTo #8878

Merged

Exit when calling root command with unrecognized option #8868

Merged

phsft-bot mentioned this pull request Jul 6, 2023

[RF] Add methods to create owning RooFit proxies via std::unique_ptr #12924

Merged

[cxxmodules] Start generating modules in rootcling. #930

[cxxmodules] Start generating modules in rootcling. #930

Uh oh!

Conversation

Teemperor commented Sep 4, 2017

Uh oh!

phsft-bot commented Sep 4, 2017

Uh oh!

phsft-bot commented Sep 4, 2017

Errors:

Uh oh!

phsft-bot commented Sep 4, 2017

Errors:

Uh oh!

phsft-bot commented Sep 4, 2017

Errors:

Uh oh!

phsft-bot commented Sep 4, 2017

Errors:

Uh oh!

phsft-bot commented Sep 4, 2017

Errors:

Uh oh!

phsft-bot commented Sep 4, 2017

Uh oh!

phsft-bot commented Sep 4, 2017

Uh oh!

Teemperor commented Sep 4, 2017

Uh oh!

phsft-bot commented Sep 4, 2017

Uh oh!

phsft-bot commented Sep 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Sep 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Sep 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Sep 4, 2017

Failing tests:

Uh oh!

phsft-bot commented Sep 4, 2017

Failing tests:

Uh oh!

Axel-Naumann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment