[cxxmodules] Unify *32 dictionaries into one #936
Conversation
|
Starting build on |
Teemperor
force-pushed
the
Unify32Dicts
branch
from
297b56b to
f2ba925
Compare
Teemperor
changed the title
|
Starting build on |
|
@phsft-bot build |
|
Starting build on |
With C++ modules we are supposed to have a unique module name where each module contains different headers. But smatrix(32) or genvector(32) currently have the same contents and also the same name. As we anyway also have a combined LinkDef file for both cases, we just unify those two dictionaries when using runtime_modules and have only a single module in the end which has an unique name and unique contents.
|
(As it seems you discovered :)), the source file of those dictionaries must be distinct as one of the mechanism used for bootstrapping is function overload resolution based on the requested types. However since TemplateName and TemplateName<Double32_t> are, for the C++ compiler, the same name we end with both a compilation error and if the compile succeeds then a call to the 'wrong' function and/or a missing call to one of the two (similar) overloads. |
3 participants
With C++ modules we are supposed to have a unique module name where
each module contains different headers. But smatrix(32) or genvector(32)
currently have the same contents and also the same name. As we
anyway also have a combined LinkDef file for both cases, we just
unify those two dictionaries when using runtime_modules and have
only a single module in the end which has an unique name and
unique contents.