Provide different tests for JSON output #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
requested changes
May 27, 2017
| $(TestDiff) | ||
|
|
||
| RootClasses: RootClasses.log | ||
| $(TestDiff) |
Member
There was a problem hiding this comment.
Please add
RootClasses.log: test_classes_h.$(DllSuf)
for all the cases that uses test_classes.h+ to allow for parallel builds.
Member
Author
There was a problem hiding this comment.
I add correspondent rule in Makefile
root/io/json/test_classes.h
Outdated
| } | ||
| virtual ~TJsonEx3() | ||
| { | ||
| //delete[] fBool; |
Member
Author
There was a problem hiding this comment.
This was due to missing copy constructor.
I used this class in std::vector and arrays pointers were copied
Now class should work correctly.
pcanal
reviewed
May 27, 2017
root/io/json/test_classes.h
Outdated
| TJsonEx6(bool setvalues = false) | ||
| { | ||
| for (int n=0;n<3;n++) { | ||
| fPtr1[n] = 0; |
Member
There was a problem hiding this comment.
whereever you have 0 meaning null pointer, can you use 'nullptr'? thanks.
Member
Author
|
Philippe - you are too fast, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included are several classes; testing most kinds of streamer elements.
Will work only after merging root-project/root#580