Skip to content

Check URDF to distinguish fixed joints from floating joints. Floating…#32

Merged
isucan merged 1 commit intoros:indigo-develfrom
shadow-robot:fix_issue#19
Sep 24, 2015
Merged

Check URDF to distinguish fixed joints from floating joints. Floating…#32
isucan merged 1 commit intoros:indigo-develfrom
shadow-robot:fix_issue#19

Conversation

@toliver
Copy link
Copy Markdown
Contributor

@toliver toliver commented Sep 1, 2015

… joints are ignored by the publisher (no segment is added for them).

Fixes #19

Maybe this warning should be modified to make it clear that it happens at the KDL level only, but the robot_state_publisher is still able to distinguish.

@ugocupcic
Copy link
Copy Markdown

Hi,

Anything we can do to help speeding up that merge?

Cheers,

@isucan
Copy link
Copy Markdown
Contributor

isucan commented Sep 24, 2015

This looks good, but can you make the request against the jade branch?

isucan added a commit that referenced this pull request Sep 24, 2015
Check URDF to distinguish fixed joints from floating joints. Floating…
@isucan isucan merged commit c7fd32e into ros:indigo-devel Sep 24, 2015
@isucan
Copy link
Copy Markdown
Contributor

isucan commented Sep 24, 2015

On further consideration and discussion with @wjwwood, this has a low chance of causing problems, so merged in indigo. Thank you for your fix!

@ugocupcic
Copy link
Copy Markdown

OK great thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants