Use critical section instead of disabling interrupts #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces an interruption-free section inside
Peripherals::take()with more generic critical section usingcritical_sectioncrate.Critical sections implemented with just disabling interrupts are unsound on multicore environments, because other core can still modify data.
critical_sectioncrate can mitigate this problem because it can be implemented in multicore-safe way, as inrp2040-hal.Also, it improves compatibility with newer, unreleased version of
cortex-mwhich has different signature ofinterrupt::free.