Skip to content

Ignore noisy webgl params #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Ignore noisy webgl params #1016

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6dcc18
`isContextLost` is particularly noisy, being called almost constantly…
eoghanmurray Oct 7, 2022
3083cff
Apply formatting changes
eoghanmurray Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply formatting changes
  • Loading branch information
@eoghanmurray @github-actions
eoghanmurray authored and github-actions[bot] committed Oct 7, 2022
commit 3083cff7e7d1e4e177bc2bb4713313dbdf3c58ae
8 changes: 7 additions & 1 deletion packages/rrweb/src/record/observers/canvas/webgl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ function patchGLPrototype(
for (const prop of props) {
if (
//prop.startsWith('get') || // e.g. getProgramParameter, but too risky
['isContextLost', 'canvas', 'drawingBufferWidth', 'drawingBufferHeight'].includes(prop)) {
[
'isContextLost',
'canvas',
'drawingBufferWidth',
'drawingBufferHeight',
].includes(prop)
) {
// skip read only propery/functions
continue;
}
Expand Down