Skip to content

Chore: Move most types from rrweb to @rrweb/types package #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2022
Merged

Chore: Move most types from rrweb to @rrweb/types package #1031

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ceda3aa
Chore: Add move most types from rrweb to @rrweb/types package
Juice10 Oct 20, 2022
bab2941
Split off type imports
Juice10 Oct 20, 2022
d571ea3
Split off type import to its own line
Juice10 Oct 20, 2022
b3ead33
Get vite to generate type definitions
Juice10 Oct 21, 2022
cc47ee3
Apply formatting changes
Juice10 Oct 21, 2022
b9f43b8
noEmit not allowed in tsconfig, moved it to build step
Juice10 Oct 21, 2022
0c41ba3
Merge branch '@juice10/@rrweb/types' of https://github.com/rrweb-io/r…
Juice10 Oct 21, 2022
a5281c8
Align version of @rrweb/types with main rrweb package
Juice10 Oct 22, 2022
c21126d
Move up keywords
Juice10 Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
noEmit not allowed in tsconfig, moved it to build step
  • Loading branch information
@Juice10
Juice10 committed Oct 21, 2022
commit b9f43b82989ab497a4d5affc11dee489009b29cf
2 changes: 1 addition & 1 deletion packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.1",
"scripts": {
"dev": "vite",
"build": "tsc && vite build",
"build": "tsc -noEmit && vite build",
"check-types": "tsc -noEmit",
"prepublish": "npm run build",
"lint": "yarn eslint src/**/*.ts"
Expand Down
3 changes: 1 addition & 2 deletions packages/types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"lib": ["es6", "dom"],
"skipLibCheck": true,
"declaration": true,
"importsNotUsedAsValues": "error",
"noEmit": true
"importsNotUsedAsValues": "error"
},
"compileOnSave": true,
"exclude": ["test"],
Expand Down