Skip to content

Cross origin iframe support #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Nov 16, 2022
Merged

Cross origin iframe support #1035

Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
1cabfbf
Add `recordCrossOriginIframe` setting
Juice10 Oct 24, 2022
bd0d633
Set up messaging between iframes
Juice10 Oct 25, 2022
017bd3e
should emit full snapshot event from iframe as mutation event
Juice10 Oct 25, 2022
f1c8d0b
this.mirror was dropped on attachIframe
Juice10 Oct 25, 2022
580ed6a
should use unique id for child of iframe
Juice10 Oct 25, 2022
f248392
Cross origin iframe recording in `yarn live-stream`
Juice10 Oct 25, 2022
e34e856
Root iframe check thats supported by firefox
Juice10 Oct 26, 2022
7e6a5ee
Live stream: Inject script in all frames
Juice10 Oct 26, 2022
a8542b8
Record same origin and cross origin iframes differently
Juice10 Oct 26, 2022
6b5a9c6
Should map Input events correctly
Juice10 Oct 26, 2022
fee185a
Turn on other tests
Juice10 Oct 26, 2022
cb1e065
Fix compatibility with newer puppeteer
Juice10 Oct 26, 2022
c54b981
puppeteer vs 12 seems stable without to many changes needed
Juice10 Oct 26, 2022
505ba2c
normalize port numbers in snapshots
Juice10 Oct 26, 2022
15c2cc0
Handle scroll and ViewportResize events in cross origin iframe
Juice10 Oct 26, 2022
9febf1c
Correctly map cross origin mutations
Juice10 Oct 26, 2022
5fa4634
Map selection events for cross origin iframes
Juice10 Oct 26, 2022
05a1fbc
Map canvas mutations for cross origin iframes
Juice10 Oct 26, 2022
8ea496c
Update snapshot to include canvas events
Juice10 Oct 26, 2022
8ac677b
Skip all meta events
Juice10 Oct 26, 2022
92b9594
Support custom events as best we can in cross origin iframes
Juice10 Oct 26, 2022
20a39e6
Use earliest version of puppeteer that works with cross origin live-s…
Juice10 Oct 26, 2022
738a1fc
Map mouse/touch interaction events
Juice10 Oct 27, 2022
6635390
Update snapshots for correctly mapped click events
Juice10 Oct 27, 2022
f884878
Tweak tests for new puppeteer version
Juice10 Oct 27, 2022
a598429
Map MediaInteraction correctly for cross origin iframes
Juice10 Oct 27, 2022
0f91e98
Make tests consistent between high and low dpi devices
Juice10 Oct 27, 2022
784c2da
Make test less flaky
Juice10 Oct 27, 2022
50c907e
Make test less flaky
Juice10 Oct 27, 2022
97b15ed
Make test less flaky
Juice10 Oct 27, 2022
89b14bd
Make test less flaky
Juice10 Oct 27, 2022
cb26153
Add support for styles in cross origin iframes
Juice10 Oct 27, 2022
fc2ad8c
Map traditional stylesheet mutations on cross origin iframes
Juice10 Oct 27, 2022
a348d33
Add todo
Juice10 Oct 27, 2022
bbdea9b
Add iframe mirror
Juice10 Oct 28, 2022
4bca6bb
Get iframe manager to use iframe mirrors internally
Juice10 Oct 31, 2022
8147d7f
Rename `IframeMirror` to `CrossOriginIframeMirror`
Juice10 Oct 31, 2022
7f23d34
Setup basic cross origin canvas webrtc streaming
Juice10 Oct 31, 2022
da4c53b
Clean up removed canvas elements
Juice10 Oct 31, 2022
e0e1a9b
reset style mirror on new full snapshot
Juice10 Nov 1, 2022
2e64e5e
Fix cross origin canvas webrtc streaming
Juice10 Nov 2, 2022
7d9bcb7
Make emit optional
Juice10 Nov 2, 2022
8bc678f
Run tests on github actions
Juice10 Nov 2, 2022
7c985d0
Upload image artifacts from failed tests
Juice10 Nov 2, 2022
48b8c1e
Use newer github actions
Juice10 Nov 2, 2022
dc02163
Test: hopefully adding more wait will fix it
Juice10 Nov 2, 2022
1a9c164
add extra wait
Juice10 Nov 2, 2022
c51e84f
Fix image snapshot tests
Juice10 Nov 2, 2022
6eb1d2e
Make tests run with new puppeteer version
Juice10 Nov 2, 2022
728e779
upgrade eslint-plugin-jest
Juice10 Nov 2, 2022
7b5c3cf
Chore: Remove travis ci as ci's running on github actions
Juice10 Nov 2, 2022
99ab6d7
Chore: Support recording cross origin iframe in repl
Juice10 Nov 3, 2022
2963357
Force developers to update the cross origin iframe mapping when addin…
Juice10 Nov 3, 2022
243530d
Document cross origin iframe recording
Juice10 Nov 3, 2022
f3705b3
Docs: cross origin iframes recording methods
Juice10 Nov 3, 2022
4a5e4cf
Docs: AI translated, cross origin iframe recording
Juice10 Nov 3, 2022
05632d2
Merge branch 'master' of https://github.com/rrweb-io/rrweb into cross…
Juice10 Nov 4, 2022
522cadb
rename getParentId to getId
Juice10 Nov 4, 2022
1608da3
Migrate to @rrweb/types
Juice10 Nov 4, 2022
1d92dcc
Run on pull request
Juice10 Nov 4, 2022
1e6630c
Merge remote-tracking branch 'origin/master' into cross-origin-iframes
YunFeng0817 Nov 7, 2022
5ea363d
doc: improve Chinese doc
YunFeng0817 Nov 8, 2022
22eb80a
Rename `parentId` to `Id`
Juice10 Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Upload image artifacts from failed tests
  • Loading branch information
@Juice10
Juice10 committed Nov 2, 2022
commit 7c985d0da3af8a8ac3ad125074d2615603ec6e07
8 changes: 8 additions & 0 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,11 @@ jobs:

- name: Run tests
run: xvfb-run --server-args="-screen 0 1920x1080x24" yarn test

- name: Upload diff images to GitHub
uses: actions/upload-artifact@v3
if: failure()
with:
name: image-diff
path: packages/rrweb/test/e2e/__image_snapshots__/__diff_output__/*.png
if-no-files-found: ignore