feat: Guard against missing window.CSSStyleSheet
#1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/guard-against-cssstylesheet-rrweb
branch
from
f558568 to
f426d3e
Compare
YunFeng0817
approved these changes
Jan 12, 2023
Member
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The guard is good and I think can add it for sure. BTW, do you figure out the root cause of the error? I'm worried that this PR may not fix the bug from the root.
Juice10
approved these changes
Jan 12, 2023
Member
Juice10
left a comment
Juice10
left a comment
There was a problem hiding this comment.
Im surprised this is needed since the CSSStyleSheet API seems to be supported by all browsers: https://caniuse.com/mdn-api_cssstylesheet
Contributor
Author
|
Yeah, we thought the same, but kept getting bug reports for this. I'd say one of two things is happening: Either A) it is somehow related to some rather obscure browser or B) something is messing with the global objects. 😬 |
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a lot of reports from users of sentry that seem to originate from browsers where
window.CSSStyleSheetis not available. See e.g. getsentry/sentry-javascript#6534This adds a simple guard that skips stylesheet observing when this is not defined.