Skip to content

improve rrdom robustness #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 9, 2023
Merged

improve rrdom robustness #1091

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
213848c
add more check to rrdom to make diff algorithm more robust
YunFeng0817 Jan 10, 2023
477e472
fix: selector match in iframe is case-insensitive
YunFeng0817 Jan 12, 2023
011abf1
test: increase timeout value for Jest
YunFeng0817 Jan 12, 2023
5f319f1
improve code style
YunFeng0817 Jan 12, 2023
d945110
Merge branch 'master' into rrdom-improve
YunFeng0817 Jan 30, 2023
72bd7e6
fix: failed to execute insertBefore on Node in the diff function
YunFeng0817 Jan 31, 2023
1dd69d8
refactor diff function to make the code cleaner
YunFeng0817 Feb 1, 2023
fb6db8c
fix: virtual nodes are passed to plugin's onBuild function
YunFeng0817 Feb 1, 2023
fee57d8
refactor the diff function and adjust the order of diff work.
YunFeng0817 Feb 1, 2023
8eaf2d3
call afterAppend hook in a consistent traversal order
YunFeng0817 Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve code style
  • Loading branch information
@YunFeng0817
YunFeng0817 committed Jan 12, 2023
commit 5f319f1304bc885de46429024fb17a38f8664e4e
2 changes: 1 addition & 1 deletion packages/rrdom/test/diff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,7 @@ describe('diff algorithm for rrdom', () => {
* If the selector match is case insensitive, it will cause some CSS style problems in the replayer.
* This test result executed in JSDom is different from that in real browser so we use puppeteer as test environment.
*/
let browser = await puppeteer.launch();
const browser = await puppeteer.launch();
const page = await browser.newPage();
await page.goto('about:blank');

Expand Down