Skip to content

fix the statement which is getting changed by Microbundle #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2023
Merged

fix the statement which is getting changed by Microbundle #1156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
080e611
fix the statement which is getting changed by microbundle
Code-Crash Feb 27, 2023
0eec33a
Create chatty-cherries-train.md
Juice10 Feb 27, 2023
d4887fc
fix formatting.
Code-Crash Feb 27, 2023
eefc0f0
fix position of comment
Code-Crash Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix formatting.
  • Loading branch information
@Code-Crash
Code-Crash committed Feb 27, 2023
commit d4887fce49d75d6e800566d4c7ba7106c2d2f951
2 changes: 1 addition & 1 deletion .changeset/chatty-cherries-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"rrweb": patch
'rrweb': patch
---

Fix the statement which is getting changed by Microbundle
3 changes: 2 additions & 1 deletion packages/rrweb/src/record/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ function record<T = eventWithTime>(
let passEmitsToParent = false;
if (!inEmittingFrame) {
try {
if (window.parent.document) { // throws if parent is cross-origin
if (window.parent.document) {
// throws if parent is cross-origin
passEmitsToParent = false; // if parent is same origin we collect iframe events from the parent
}
} catch (e) {
Expand Down