Skip to content

improve: some websites rebuild imcomplete #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2023
Merged

improve: some websites rebuild imcomplete #1163

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08c2c27
improve: mutation.ts , loop use Set replace Array
Mar 1, 2023
7f4a758
improve: add try catch to utils.ts to make it robust
Mar 1, 2023
60f6c86
Create yellow-mails-cheat.md
YunFeng0817 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Create yellow-mails-cheat.md
  • Loading branch information
@YunFeng0817
YunFeng0817 authored Mar 13, 2023
commit 60f6c86f1fbdf6f18601230b51d9720ea75361e5
8 changes: 8 additions & 0 deletions .changeset/yellow-mails-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'rrweb': patch
---

Fix: some websites rebuild imcomplete

1. Some websites, addedSet in emit function is not empty, but the result converted from Array.from is empty.
2. Some websites polyfill classList functions of HTML elements. Their implementation may throw errors and cause the snapshot to fail. I add try-catch statements to make the code robust.