Skip to content

Guard against redefinition of Date.now #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2023
Merged

Guard against redefinition of Date.now #1196

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4eacc73
Guard against presence of likely older third party libraries which (r…
eoghanmurray Mar 31, 2023
8edb68a
Apply formatting changes
eoghanmurray Mar 31, 2023
cd8dc59
(remove nowTimestamp import where Date.now() is not used)
eoghanmurray Mar 31, 2023
8948d00
Add a PURE marker so an empty `ìf` statement doesn't show up in the r…
eoghanmurray Mar 31, 2023
d3b67af
Update packages/rrweb/src/utils.ts
eoghanmurray Apr 12, 2023
bbcc656
Create little-radios-thank.md
eoghanmurray Apr 13, 2023
05d4d93
Apply formatting changes
eoghanmurray Apr 13, 2023
7d1c0f0
Update .changeset/little-radios-thank.md
Juice10 Jun 2, 2023
005f649
Apply formatting changes
Juice10 Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/rrweb/src/utils.ts 
Fix typing issue with regex against `Date.now()`

Co-authored-by: Justin Halsall <[email protected]>
  • Loading branch information
@eoghanmurray @Juice10
eoghanmurray and Juice10 committed Apr 13, 2023
commit d3b67af85702355ebaaedce8905bca4bb04dd2a0
2 changes: 1 addition & 1 deletion packages/rrweb/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export function patch(
// guard against old third party libraries which redefine Date.now
let nowTimestamp = Date.now;

if (!(/*@__PURE__*/ /[1-9][0-9]{12}/.test(Date.now()))) {
if (!(/*@__PURE__*/ /[1-9][0-9]{12}/.test(Date.now().toString()))) {
// they have already redefined it! use a fallback
nowTimestamp = () => new Date().getTime();
}
Expand Down