Skip to content

fix: Set finished=false in goto instead of handleProgressClick #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2023
Merged

fix: Set finished=false in goto instead of handleProgressClick #1198

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b7a89
Reset the finished flag in goto
charliegracie Apr 5, 2023
d18721d
Create controller-finish-flag.md
charliegracie Apr 7, 2023
9935e99
Update controller-finish-flag.md
charliegracie Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reset the finished flag in goto 
If the player finishes a replaying a video the `finished` boolean is set to true. This allows the video to be restarted at the beginning if the controller is toggled again. If a user clicks on the progress bar the `finished` boolean is reset so if the `toggle` API is called it starts at the right place. If a user programatically calls `goto` which is the underlying API that handling the progress click calls the next invocation of `toggle` will start the video at the beginning instead of the proper location.
  • Loading branch information
@charliegracie
charliegracie authored Apr 5, 2023
commit c3b7a897dc19b7849c70e17dd715ce2212166054
2 changes: 1 addition & 1 deletion packages/rrweb-player/src/Controller.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
export const goto = (timeOffset: number, play?: boolean) => {
currentTime = timeOffset;
pauseAt = false;
finished = false;
const resumePlaying =
typeof play === 'boolean' ? play : playerState === 'playing';
if (resumePlaying) {
Expand Down Expand Up @@ -250,7 +251,6 @@
percent = 1;
}
const timeOffset = meta.totalTime * percent;
finished = false;
goto(timeOffset);
};

Expand Down