Skip to content

perf(genAdds): refactor recursive procedure to iterative #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

perf(genAdds): refactor recursive procedure to iterative #1277

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0d630e4
ref(genAdds): refactor to iterative
JonasBa Aug 7, 2023
82dab76
`return` should have been converted to `continue` for the iterative v…
eoghanmurray Aug 8, 2023
337b05d
No need for a separately named `genAdds` function if it's not recursive
eoghanmurray Aug 8, 2023
deeb233
ref(mutation): use arr push
JonasBa Aug 17, 2023
d23ce75
ref(mutation): update snapshot
JonasBa Aug 17, 2023
30548a2
perf(mutation): dont reschedule nodes if they exist in the set
JonasBa May 24, 2024
2b8de82
eoghan: add way to call deep recursive test (already added in #1489)
JonasBa May 24, 2024
20f1ca7
fix test cmd
JonasBa Jul 17, 2024
bfe56c4
fix benchmark boilerplate code
JonasBa Jul 18, 2024
6059038
run prettier
JonasBa Jul 18, 2024
77d8762
reverse iterate to fix test
JonasBa Jul 18, 2024
5e3808a
run prettier
JonasBa Jul 18, 2024
4a984b0
use for loop
JonasBa Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix benchmark boilerplate code
  • Loading branch information
@JonasBa
JonasBa committed Jul 18, 2024
commit bfe56c47af9c21d62a3b43034ba7cddc43fa21a0
20 changes: 7 additions & 13 deletions packages/rrweb/test/benchmark/dom-mutation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,6 @@ describe('benchmark: mutation observer', () => {
return fs.readFileSync(filePath, 'utf8');
};

const addRecordingScript = async (page: Page) => {
// const scriptUrl = `${getServerURL(server)}/rrweb-1.1.3.js`;
const scriptUrl = `${getServerURL(server)}/rrweb.umd.cjs`;
await page.evaluate((url) => {
const scriptEl = document.createElement('script');
scriptEl.src = url;
document.head.append(scriptEl);
}, scriptUrl);
await page.waitForFunction('window.rrweb');
};

for (const suite of suites) {
it(suite.title, async () => {
page = await browser.newPage();
Expand All @@ -110,12 +99,17 @@ describe('benchmark: mutation observer', () => {
const loadPage = async () => {
if ('html' in suite) {
await page.goto('about:blank');
const code = fs.readFileSync(path.resolve(__dirname, '../../dist/rrweb.umd.cjs')).toString()
await page.setContent(`<html>
<script>
${code.toString()}
</script>
</html>`);

await page.setContent(getHtml.call(this, suite.html));
} else {
await page.goto(suite.url);
}

await addRecordingScript(page);
};

const getDuration = async (): Promise<number> => {
Expand Down