Skip to content

Masking: Avoid the repeated calls to closest when recursing through the DOM #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Masking: Avoid the repeated calls to closest when recursing through the DOM #1349

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0dda219
masking: avoid the repeated calls to `closest` when recursing through…
eoghanmurray Nov 8, 2023
dac89a1
The split into needMaskingText/elementNeedsTextMasked was ugly and in…
eoghanmurray Nov 8, 2023
bae0739
Remove comments added before the explicit `checkAncestors` argument w…
eoghanmurray Nov 8, 2023
b5843a7
We didn't have any explicit characterData mutation tests - add one
eoghanmurray Nov 8, 2023
aa046c4
I missed the checkAncestors:true argument on needMaskingText with the…
eoghanmurray Nov 8, 2023
5ce0f4e
Create thin-vans-applaud.md
eoghanmurray Nov 8, 2023
d19e922
Fix eslint
eoghanmurray Nov 13, 2023
1b37e33
Avoid calls to `el.matches` when on a leaf node, e.g. a `<br/>`
eoghanmurray Nov 15, 2023
6320751
Apply formatting changes
eoghanmurray Nov 15, 2023
36618ab
Fixup eslint
eoghanmurray Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove comments added before the explicit checkAncestors argument w… 
…hich is now self evident
  • Loading branch information
@eoghanmurray
eoghanmurray committed Nov 8, 2023
commit bae073996680432843a8a7a972abedf5412bffec
2 changes: 0 additions & 2 deletions packages/rrweb-snapshot/src/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,6 @@ export function needMaskingText(
if (el === null) return false;
if (typeof maskTextClass === 'string') {
if (checkAncestors) {
// we haven't already checked parents
if (el.closest(`.${maskTextClass}`)) return true;
} else {
if (el.classList.contains(maskTextClass)) return true;
Expand All @@ -330,7 +329,6 @@ export function needMaskingText(
}
if (maskTextSelector) {
if (checkAncestors) {
// we haven't already checked parents
if (el.closest(maskTextSelector)) return true;
} else {
if (el.matches(maskTextSelector)) return true;
Expand Down