Skip to content

Fix serialization and mutation of <textarea> elements #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 1, 2023
Merged

Fix serialization and mutation of <textarea> elements #1351

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
476af5b
Fix serialization and mutation of <textarea> elements taking account …
eoghanmurray Nov 9, 2023
a807888
Create rare-adults-sneeze.md
eoghanmurray Nov 9, 2023
cbfc506
Bug fix and regression test for #112
eoghanmurray Nov 9, 2023
f800b19
Fix that textarea values were being missed by the masking system if t…
eoghanmurray Nov 9, 2023
d002630
Need a longer seek here to account for slower recording during testing
eoghanmurray Nov 9, 2023
4bc169a
Make rrweb-snapshot behave like rrweb in that `yarn test` causes a re…
eoghanmurray Nov 9, 2023
69c9aa3
Simplify by always storing the textarea value in the `.value` attribu…
eoghanmurray Nov 10, 2023
ee4aaac
replaceChildNodes is not yet available in RRDom (this replacement cod…
eoghanmurray Nov 10, 2023
71203c7
Not needed since 8e47ca1021ebb4fc03 - #1157
eoghanmurray Nov 11, 2023
e9b0318
Update packages/rrweb/test/integration.test.ts
Juice10 Dec 1, 2023
302f855
Improvements to test documentation; with Justin's help for better com…
eoghanmurray Dec 1, 2023
9df40e4
Apply formatting changes
eoghanmurray Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Not needed since 8e47ca1 - #1157
  • Loading branch information
@eoghanmurray
eoghanmurray committed Nov 28, 2023
commit 71203c7c6b61c54f103885df6d2a213aa1f0f5f1
1 change: 0 additions & 1 deletion packages/rrweb-snapshot/src/rebuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
tagMap,
elementNode,
BuildCache,
attributes,
legacyAttributes,
} from './types';
import { isElement, Mirror, isNodeMetaEqual } from './utils';
Expand Down