Skip to content

replay :hover rewrite - instead mutate stylesheets #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

replay :hover rewrite - instead mutate stylesheets #1480

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b469626
replay stylesheet modification: switch to model where we adapt the cs…
eoghanmurray May 17, 2024
bcbe95c
The sheet was not available on the rebuild, so wait to call `adaptSty…
eoghanmurray May 20, 2024
2afa676
Add changeset
eoghanmurray May 20, 2024
2f886ad
Satisfy eslint
eoghanmurray May 20, 2024
5cfe00b
Passing down the hackCss option is no longer needed
eoghanmurray May 20, 2024
bda2483
Revert `norm` function as will be reimplementing properly
eoghanmurray May 23, 2024
0a04127
Use loose matching when comparing css strings as we don't need to gua…
eoghanmurray May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add changeset
  • Loading branch information
@eoghanmurray
eoghanmurray committed Jun 21, 2024
commit 2afa67636f533e21622a1132a5112492522ecc44
7 changes: 7 additions & 0 deletions .changeset/replay-mutate-stylesheets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"rrweb-snapshot": patch
"rrweb": patch
"rrdom": patch
---

Change to adding hover classes on replay directly to the rendered stylesheets rather than parsing and modifying the css text