Skip to content

fix: nested stylesheets should have absolute URLs #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 25, 2024
Merged

fix: nested stylesheets should have absolute URLs #1533

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d685bc6
Replace relative URLs with absolute URLs when stringifying stylesheets
jeffdnguyen Jul 11, 2024
c6c0ee3
Add test to show desired behavior for imported stylesheets from seper…
jeffdnguyen Jul 16, 2024
f69e8f3
Add changeset
jeffdnguyen Jul 16, 2024
27432e2
Rename `absoluteToStylesheet` to `absolutifyURLs` and call it once af…
jeffdnguyen Jul 16, 2024
6ca68b8
Don't create the intermediary array of the spread operator
eoghanmurray Jul 17, 2024
ddebff5
Formalize that `stringifyRule` should expect a sheet href
eoghanmurray Jul 17, 2024
04b3fc6
Ensure a <style> element can also import and gets it's url absolutized
eoghanmurray Jul 17, 2024
0c0ceb9
Apply formatting changes
eoghanmurray Jul 17, 2024
f4bfd73
Handle case where non imported stylesheet has relative urls that need…
jeffdnguyen Jul 17, 2024
72f6a68
Clarify in test files where jpegs are expected to appear in absolutif…
jeffdnguyen Jul 17, 2024
772f64c
Movee absolutifyURLs call for import rules out of trycatch
jeffdnguyen Jul 18, 2024
8edb9fa
Add a benchmarking test for stringifyStylesheet
eoghanmurray Jul 19, 2024
e4d1861
Avoid the duplication on how to fall back
eoghanmurray Jul 19, 2024
74f3758
Add explanatory comment
eoghanmurray Jul 19, 2024
acf1cb9
Code style: more compact
eoghanmurray Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure a <style> element can also import and gets it's url absolutized
  • Loading branch information
@eoghanmurray @jeffdnguyen
eoghanmurray authored and jeffdnguyen committed Jul 17, 2024
commit 04b3fc69622b68478cc258985b5d66fe59abf754
1 change: 1 addition & 0 deletions packages/rrweb-snapshot/test/__snapshots__/integration.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,7 @@ exports[`integration tests > [html file]: with-style-sheet-with-import.html 1`]
<meta http-equiv=\\"X-UA-Compatible\\" content=\\"ie=edge\\" />
<title>with style sheet with import</title>
<style>@import url(\\"//fonts.googleapis.com/css2?family=Open+Sans:wght@400;600;700&amp;family=Roboto:wght@100;300;400;500;700&amp;display=swap\\\\\\"\\");body { margin: 0px; background: url(\\"http://localhost:3030/a.jpg\\"); border-image: url(\\"data:image/svg+xml;utf8,&lt;svg xmlns=\\\\\\"http://www.w3.org/2000/svg\\\\\\" x=\\\\\\"0px\\\\\\" y=\\\\\\"0px\\\\\\" viewBox=\\\\\\"0 0 256 256\\\\\\"&gt;&lt;g&gt;&lt;g&gt;&lt;polygon points=\\\\\\"79.093,0 48.907,30.187 146.72,128 48.907,225.813 79.093,256 207.093,128\\\\\\"/&gt;&lt;/g&gt;&lt;/g&gt;&lt;/svg&gt;\\") 100% / 1 / 0 stretch; }p { color: red; background: url(\\"http://localhost:3030/css/b.jpg\\"); }body &gt; p { color: yellow; }body { margin: 0px; background: url(\\"http://localhost:3030/c.jpg\\"); border-image: url(\\"data:image/svg+xml;utf8,&lt;svg xmlns=\\\\\\"http://www.w3.org/2000/svg\\\\\\" x=\\\\\\"0px\\\\\\" y=\\\\\\"0px\\\\\\" viewBox=\\\\\\"0 0 256 256\\\\\\"&gt;&lt;g&gt;&lt;g&gt;&lt;polygon points=\\\\\\"79.093,0 48.907,30.187 146.72,128 48.907,225.813 79.093,256 207.093,128\\\\\\"/&gt;&lt;/g&gt;&lt;/g&gt;&lt;/svg&gt;\\") 100% / 1 / 0 stretch; }p { color: red; background: url(\\"http://localhost:3030/alt-css/d.jpg\\"); }body &gt; p { color: yellow; }</style>
<style>body { margin: 0px; background: url(\\"http://localhost:3030/c.jpg\\"); border-image: url(\\"data:image/svg+xml;utf8,&lt;svg xmlns=\\\\\\"http://www.w3.org/2000/svg\\\\\\" x=\\\\\\"0px\\\\\\" y=\\\\\\"0px\\\\\\" viewBox=\\\\\\"0 0 256 256\\\\\\"&gt;&lt;g&gt;&lt;g&gt;&lt;polygon points=\\\\\\"79.093,0 48.907,30.187 146.72,128 48.907,225.813 79.093,256 207.093,128\\\\\\"/&gt;&lt;/g&gt;&lt;/g&gt;&lt;/svg&gt;\\") 100% / 1 / 0 stretch; }p { color: red; background: url(\\"http://localhost:3030/alt-css/d.jpg\\"); }body &gt; p { color: yellow; }section { background: url(\\"http://localhost:3030/c.jpg\\"); }</style>
</head><body>
</body></html>"
`;
Expand Down
4 changes: 4 additions & 0 deletions packages/rrweb-snapshot/test/html/with-style-sheet-with-import.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>with style sheet with import</title>
<link rel="stylesheet" href="/css/style-with-import.css">
<style>
@import '../alt-css/alt-style.css';
section { background: url('./c.jpg'); }
</style>
</head>

<body>
Expand Down