Skip to content

perf: improve serialize text #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

perf: improve serialize text #1537

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3c27e9
perf: improve serialize text
JonasBa Jul 18, 2024
d121ec9
add changeset
JonasBa Jul 18, 2024
3dd34f8
fix
JonasBa Jul 18, 2024
4ece15e
format
JonasBa Jul 18, 2024
c7615f0
Merge branch 'master' into jb/perf/attribute-text
JonasBa Sep 19, 2024
b679fc0
fix bad merge
JonasBa Sep 19, 2024
a9dd5c3
use correct parent
JonasBa Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bad merge
  • Loading branch information
@JonasBa
JonasBa committed Sep 19, 2024
commit b679fc0f21245c982cc62ae92a9d4555b4b0ab9e
5 changes: 3 additions & 2 deletions packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,12 +268,13 @@ export default class MutationBuffer {
const texts = [];
for (let i = 0; i < input.length; i++) {
const n = input[i].node;
const id = this.mirror.getId(n);
if (n.parentNode && (n.parentNode as Element).tagName === 'TEXTAREA') {
const parent = dom.parentNode(n);
if (parent && (parent as Element).tagName === 'TEXTAREA') {
// the node is being ignored as it isn't in the mirror, so shift mutation to attributes on parent textarea
this.genTextAreaValueMutation(n.parentNode as HTMLTextAreaElement);
}

const id = this.mirror.getId(n);
if (addedIds.has(id) || !this.mirror.has(id)) {
continue;
}
Expand Down