Skip to content

chore: abstract types to shared package #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 6, 2024
Merged

chore: abstract types to shared package #1593

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5869c93
chore: update types
daibhin Nov 1, 2024
1addf77
small typing change
daibhin Nov 1, 2024
a6a8f23
fix typing issue
daibhin Nov 1, 2024
040e941
typed node
daibhin Nov 1, 2024
ac3652d
add extra lint skip
daibhin Nov 20, 2024
66632c4
Create soft-worms-tan.md
eoghanmurray Nov 29, 2024
9772049
add changeset
daibhin Nov 30, 2024
8ca737e
Merge branch 'dn-chore/type-changes' of github.com:daibhin/rrweb into…
daibhin Dec 6, 2024
6e62b4c
update changeset
daibhin Dec 6, 2024
cbdb5e8
Update soft-worms-tan.md
Juice10 Dec 6, 2024
8508bed
Update soft-worms-tan.md
Juice10 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typed node
  • Loading branch information
@daibhin
daibhin committed Nov 1, 2024
commit 040e94107308034af13dfe49463477a7aea87dc6
5 changes: 3 additions & 2 deletions packages/rrdom/src/diff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { NodeType as RRNodeType } from '@rrweb/types';
import type {
canvasMutationData,
canvasEventWithTime,
elementNode,
inputData,
scrollData,
styleDeclarationData,
Expand Down Expand Up @@ -338,8 +339,8 @@ function diffProps(

for (const name in newAttributes) {
const newValue = newAttributes[name];
const sn = rrnodeMirror.getMeta(newTree);
if (sn?.type == RRNodeType.Element && sn?.isSVG && NAMESPACES[name])
const sn = rrnodeMirror.getMeta(newTree) as elementNode | null;
if (sn?.isSVG && NAMESPACES[name])
oldTree.setAttributeNS(NAMESPACES[name], name, newValue);
else if (newTree.tagName === 'CANVAS' && name === 'rr_dataURL') {
const image = document.createElement('img');
Expand Down
Loading