Skip to content

Fix splitCssText again #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 6, 2025
Merged

Fix splitCssText again #1640

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fb694b2
Fix up the 'should replace the existing DOM nodes on iframe navigatio…
eoghanmurray Jan 23, 2025
5962d03
Fix a case I previously forgot about, when there are multiple matches…
eoghanmurray Jan 29, 2025
08a80ab
Failing example extracted from large files identified by Paul D'Ambra…
eoghanmurray Jan 29, 2025
43df807
Fix that we weren't stopping when going from many matches to zero mat…
eoghanmurray Jan 29, 2025
d59c1ef
Avoid (probably) a happydom bug
eoghanmurray Jan 29, 2025
21beccb
Disabliing to prove failure
eoghanmurray Jan 29, 2025
e789129
Make the matches go from 'many' to 'none'
eoghanmurray Jan 29, 2025
a72c4e1
Pick the best when there are many splits by looking at previous chunk…
eoghanmurray Jan 29, 2025
b3a5a12
This seems more straightforward
eoghanmurray Jan 29, 2025
e02e608
Rename some variables for clarity
eoghanmurray Jan 29, 2025
0347a36
yarn format
eoghanmurray Jan 29, 2025
d0fb0c5
Add changeset
eoghanmurray Jan 29, 2025
e5a9550
Mention what triggers the bug
eoghanmurray Jan 29, 2025
01d96bb
Solve the same bug another way; by normalization
eoghanmurray Jan 29, 2025
86796ac
Apply formatting changes
eoghanmurray Jan 29, 2025
3a452e3
Don't go past 100 iterations trying to find a unique substring
eoghanmurray Jan 29, 2025
7a32e49
Add a tscomment to explain the `_testNoPxNorm` test-only parameter
eoghanmurray Feb 4, 2025
5743c7e
Merge remote-tracking branch 'upstream/master' into fix-splitCssText-…
eoghanmurray Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add changeset
  • Loading branch information
@eoghanmurray
eoghanmurray committed Jan 29, 2025
commit d0fb0c5ee1a010fb2e2baf5af8eded63042e327a
6 changes: 6 additions & 0 deletions .changeset/efficiently-splitCssText-1640.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"rrweb-snapshot": patch
"rrweb": patch
---

Improve performance of splitCssText for <style> elements with large css content - see #1603
Loading