Skip to content

Don't allow video autoplay to automatically unfreeze page #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't allow video autoplay to automatically unfreeze page #1697

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9f5784
Don't allow video autoplay to automatically unfreeze page. If it's a …
eoghanmurray May 28, 2025
f365dcf
Create chilly-jeans-fail.md
eoghanmurray May 28, 2025
ec36222
Apply formatting changes
eoghanmurray May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't allow video autoplay to automatically unfreeze page. If it's a … 
…'real' playback, there should be a mount or a keyboard event which will serve to unfreeze the page. Also add other non-user events to the list (we really should have an `isUserEvent` function)
  • Loading branch information
@eoghanmurray
eoghanmurray committed May 28, 2025
commit b9f5784de8edb95ce37fa72056f0dc95f9198555
10 changes: 9 additions & 1 deletion packages/rrweb/src/record/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,15 @@ function record<T = eventWithTime>(
e.type !== EventType.FullSnapshot &&
!(
e.type === EventType.IncrementalSnapshot &&
e.data.source === IncrementalSource.Mutation
[IncrementalSource.Mutation,
IncrementalSource.MediaInteraction, // often automatic e.g. background video loop
IncrementalSource.StyleSheetRule,
IncrementalSource.CanvasMutation,
IncrementalSource.Font,
IncrementalSource.Log,
IncrementalSource.StyleDeclaration,
IncrementalSource.AdoptedStyleSheet,
].includes(e.data.source)
)
) {
// we've got a user initiated event so first we need to apply
Expand Down
Loading