Skip to content

fix: clear mutation buffer and remove mirror node on iframe pagehide event #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: clear mutation buffer and remove mirror node on iframe pagehide event #1755

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dae99fd
fix: clear mutation buffer and remove mirror node on iframe pagehide …
megboehlert Oct 23, 2025
66f882a
Apply formatting changes
megboehlert Oct 27, 2025
7b2416a
Merge branch 'master' into meg-fix-mutation-observer-leak
megboehlert Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply formatting changes
  • Loading branch information
@megboehlert @github-actions
megboehlert authored and github-actions[bot] committed Oct 27, 2025
commit 66f882a1627d938c7abea482bc7704017996d466
11 changes: 6 additions & 5 deletions packages/rrweb/src/record/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ import {
type SlimDOMOptions,
createMirror,
} from 'rrweb-snapshot';
import { initObservers, mutationBuffers, findAndRemoveIframeBuffer } from './observer';
import {
initObservers,
mutationBuffers,
findAndRemoveIframeBuffer,
} from './observer';
import {
on,
getWindowWidth,
Expand Down Expand Up @@ -437,10 +441,7 @@ function record<T = eventWithTime>(

try {
const handlers: listenerHandler[] = [];
const iframeHandlersMap = new Map<
HTMLIFrameElement,
listenerHandler
>();
const iframeHandlersMap = new Map<HTMLIFrameElement, listenerHandler>();

const observe = (doc: Document) => {
return callbackWrapper(initObservers)(
Expand Down