Skip to content

Avoid triggering a CSP (content security policy) error #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2023
Merged

Avoid triggering a CSP (content security policy) error #846

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
386a318
Fix for #816 - avoid triggering a CSP (content security policy) error…
eoghanmurray Feb 26, 2022
efcea7d
The bare unattachedDoc that I previously naively created didn't have …
eoghanmurray Apr 12, 2023
f36073d
Add a try/catch to provide some robustness in case `document.implemen…
eoghanmurray Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix for #816 - avoid triggering a CSP (content security policy) error… 
… with `.setAttribute('style')`
  • Loading branch information
@eoghanmurray
eoghanmurray committed Apr 13, 2023
commit 386a318afc2308da370ebbe96266e5f496cf93fb
3 changes: 2 additions & 1 deletion packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ export default class MutationBuffer {
if (isIgnored(m.target, this.mirror)) {
return;
}
const unattachedDoc = new Document(); // avoid upsetting original document from a Content Security point of view
switch (m.type) {
case 'characterData': {
const value = m.target.textContent;
Expand Down Expand Up @@ -543,7 +544,7 @@ export default class MutationBuffer {
}

if (attributeName === 'style') {
const old = this.doc.createElement('span');
const old = unattachedDoc.createElement('span');
if (m.oldValue) {
old.setAttribute('style', m.oldValue);
}
Expand Down