Skip to content

Remove INode (node.__sn) and use Mirror as source of truth #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 6, 2022
Merged

Remove INode (node.__sn) and use Mirror as source of truth #868

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
50785be
Move ids to weakmap
Juice10 Mar 31, 2022
39bf03e
Fix typo
Juice10 Mar 31, 2022
c6199f5
Move from INode to storing serialized data in mirror
Juice10 Apr 4, 2022
4b30d1f
Update packages/rrweb-snapshot/src/rebuild.ts
Juice10 Apr 5, 2022
fa5dfeb
Remove unnessisary `as Node` typecastings
Juice10 Apr 5, 2022
5d357c5
Remove unnessisary `as unknown as ...`
Juice10 Apr 5, 2022
f1a62c5
Remove unnessisary `as unknown as ...`
Juice10 Apr 5, 2022
8ce3861
Reset mirror when recording starts
Juice10 Apr 5, 2022
4e0c85c
API has changed for snapshot, change test to reflect that
Juice10 Apr 5, 2022
07de96d
Allow for es5 compatibility
Juice10 Apr 5, 2022
b5f4642
Remove unnessisary as unknown as ... and change test to reflect the A…
YunFeng0817 Apr 6, 2022
443e841
Merge branch 'master' into node-id-map
YunFeng0817 Apr 6, 2022
c44ddd8
Refactor mirror to remove `nodeIdMap`
Juice10 Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
API has changed for snapshot, change test to reflect that
  • Loading branch information
@Juice10
Juice10 committed Apr 5, 2022
commit 4e0c85c14a74c56c40e0bf7e7c299b290f5d77e6
12 changes: 5 additions & 7 deletions packages/rrweb-snapshot/test/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ describe('integration tests', function (this: ISuite) {
const rebuildHtml = (
await page.evaluate(`${code}
const x = new XMLSerializer();
const [snap] = rrweb.snapshot(document);
const snap = rrweb.snapshot(document);
let out = x.serializeToString(rrweb.rebuild(snap, { doc: document })[0]);
if (document.querySelector('html').getAttribute('xmlns') !== 'http://www.w3.org/1999/xhtml') {
// this is just an artefact of serializeToString
Expand Down Expand Up @@ -168,7 +168,7 @@ describe('integration tests', function (this: ISuite) {
`pre-check: images will be rendered ~326px high in BackCompat mode, and ~588px in CSS1Compat mode; getting: ${renderedHeight}px`,
);
const rebuildRenderedHeight = await page.evaluate(`${code}
const [snap] = rrweb.snapshot(document);
const snap = rrweb.snapshot(document);
const iframe = document.createElement('iframe');
iframe.setAttribute('width', document.body.clientWidth)
iframe.setAttribute('height', document.body.clientHeight)
Expand Down Expand Up @@ -205,9 +205,7 @@ iframe.contentDocument.querySelector('center').clientHeight
inlineStylesheet: false
})`);
await page.waitFor(100);
const snapshot = await page.evaluate(
'JSON.stringify(snapshot[0], null, 2);',
);
const snapshot = await page.evaluate('JSON.stringify(snapshot, null, 2);');
assert(snapshot.includes('"rr_dataURL"'));
assert(snapshot.includes('data:image/webp;base64,'));
});
Expand Down Expand Up @@ -253,7 +251,7 @@ describe('iframe integration tests', function (this: ISuite) {
});
const snapshotResult = JSON.stringify(
await page.evaluate(`${code};
rrweb.snapshot(document)[0];
rrweb.snapshot(document);
`),
null,
2,
Expand Down Expand Up @@ -302,7 +300,7 @@ describe('shadow DOM integration tests', function (this: ISuite) {
});
const snapshotResult = JSON.stringify(
await page.evaluate(`${code};
rrweb.snapshot(document)[0];
rrweb.snapshot(document);
`),
null,
2,
Expand Down