Skip to content

isBlocked factors in the selector #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 30, 2022
Merged

isBlocked factors in the selector #894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
83c1866
isBlocked factors in the selector
dbseel May 10, 2022
97da83f
Ensure contains parameter is a node
dbseel May 12, 2022
2caf35e
Merge branch 'master' into master
dbseel May 12, 2022
7014901
Update to latest
dbseel May 27, 2022
6ae3795
Fix blockSelector blocking for closest nodes
dbseel May 26, 2022
e4bd73c
Fix integration test
dbseel May 30, 2022
4ea8306
adding ignoreCSSAttributes to ignore the addition of certain css attr…
Jun 8, 2022
a55b7f8
tested ignoreCSSAttributes
Jun 8, 2022
f364f41
Merge branch 'master' of https://github.com/rrweb-io/rrweb
dbseel Jun 14, 2022
3341e7f
Update test snapshot
dbseel Jun 14, 2022
eedcc00
Resolve merge conflicts
dbseel Aug 19, 2022
0524137
swapped the wrapping of htmlelement to be element
dbseel Aug 19, 2022
0f1c600
Fix linter errors
dbseel Aug 19, 2022
bd4d101
Address MR feedback
dbseel Aug 29, 2022
eb76c1a
Merge branch 'master' of https://github.com/rrweb-io/rrweb
dbseel Aug 29, 2022
55387b0
Rebase
dbseel Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tested ignoreCSSAttributes
  • Loading branch information
@dbseel
Filip authored and dbseel committed Jun 14, 2022
commit a55b7f88161cda732954c8076d94270667aa0efa
3 changes: 0 additions & 3 deletions packages/rrweb/src/record/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ function record<T = eventWithTime>(
keepIframeSrcFn = () => false,
ignoreCSSAttributes = new Set([]),
} = options;
options.ignoreCSSAttributes?.forEach((s) => {
console.log(`element: ${s}`);
});

// runtime checks for user options
if (!emit) {
Expand Down
2 changes: 0 additions & 2 deletions packages/rrweb/src/record/observer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,6 @@ function initStyleDeclarationObserver(
) {
// ignore this mutation if we do not care about this css attribute
if (ignoreCSSAttributes.has(property)) {
console.log('here?');
return setProperty.apply(this, arguments);
}
const id = mirror.getId(this.parentRule?.parentStyleSheet?.ownerNode);
Expand All @@ -635,7 +634,6 @@ function initStyleDeclarationObserver(
) {
// ignore this mutation if we do not care about this css attribute
if (ignoreCSSAttributes.has(property)) {
console.log('here??');
return setProperty.apply(this, arguments);
}
const id = mirror.getId(this.parentRule?.parentStyleSheet?.ownerNode);
Expand Down
2 changes: 1 addition & 1 deletion packages/rrweb/test/__snapshots__/record.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ exports[`record captures style property changes 1`] = `
\\"source\\": 13,
\\"id\\": 9,
\\"set\\": {
\\"property\\": \\"color\\",
\\"property\\": \\"border-color\\",
\\"value\\": \\"green\\"
},
\\"index\\": [
Expand Down
37 changes: 9 additions & 28 deletions packages/rrweb/test/record.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ describe('record', function (this: ISuite) {

record({
emit: ((window as unknown) as IWindow).emit,
ignoreCSSAttributes: new Set(['color']),
});

const styleElement = document.createElement('style');
Expand All @@ -332,10 +333,18 @@ describe('record', function (this: ISuite) {
const styleSheet = <CSSStyleSheet>styleElement.sheet;
styleSheet.insertRule('body { background: #000; }');
setTimeout(() => {
// should be ignored
(styleSheet.cssRules[0] as CSSStyleRule).style.setProperty(
'color',
'green',
);

// should be captured because we did not block it
(styleSheet.cssRules[0] as CSSStyleRule).style.setProperty(
'border-color',
'green',
);

(styleSheet.cssRules[0] as CSSStyleRule).style.removeProperty(
'background',
);
Expand All @@ -345,34 +354,6 @@ describe('record', function (this: ISuite) {
assertSnapshot(ctx.events);
});

// it('does not capture style property changes when the css element is ignored', async () => {
// await ctx.page.evaluate(() => {
// const { record } = ((window as unknown) as IWindow).rrweb;

// record({
// emit: ((window as unknown) as IWindow).emit,
// ignoreCSSAttributes: new Set(['color']),
// });

// const styleElement = document.createElement('style');
// document.head.appendChild(styleElement);

// const styleSheet = <CSSStyleSheet>styleElement.sheet;
// styleSheet.insertRule('body { background: #000; }');
// setTimeout(() => {
// (styleSheet.cssRules[0] as CSSStyleRule).style.setProperty(
// 'color',
// 'green',
// );
// (styleSheet.cssRules[0] as CSSStyleRule).style.removeProperty(
// 'background',
// );
// }, 0);
// });
// await ctx.page.waitForTimeout(50);
// assertSnapshot(ctx.events);
// });

it('captures inserted style text nodes correctly', async () => {
await ctx.page.evaluate(() => {
const { record } = ((window as unknown) as IWindow).rrweb;
Expand Down