Skip to content

Remove children of Document even if doc not in mirror #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Remove children of Document even if doc not in mirror #923

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2f91c5
Remove children of Document even if doc not in mirror
Juice10 Jun 29, 2022
8b01750
fix flaky test
Juice10 Jun 29, 2022
b6d1d82
Update packages/rrdom/test/diff.test.ts
Juice10 Jun 29, 2022
4e7ae4a
Merge branch 'master' into iframe-remove-child-nodes
Juice10 Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/rrdom/test/diff.test.ts 
Co-authored-by: Yun Feng <[email protected]>
  • Loading branch information
@Juice10 @YunFeng0817
Juice10 and YunFeng0817 authored Jun 29, 2022
commit b6d1d82c103ad0b5e0e65e8efffcde1040ba9f5e
2 changes: 1 addition & 1 deletion packages/rrdom/test/diff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ describe('diff algorithm for rrdom', () => {
diff(document, rrDocument, replayer);
expect(document.childNodes.length).toBe(2);
const element = document.childNodes[0] as HTMLElement;
expect(element.DOCUMENT_TYPE_NODE).toBe(10);
expect(element.nodeType).toBe(element.DOCUMENT_TYPE_NODE);
expect(mirror.getId(element)).toEqual(1);
});
});
Expand Down