Handle negative ids in rrdom correctly + extra tests #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lize-stylesheet-contents
…web-io/rrweb into serialize-stylesheet-contents
…lize-stylesheet-contents
…/rrweb into inline-image-test-cases
…e-image-test-cases
When iframes get inserted they create untracked elements, both on the dom and rrdom side. Because they are untracked they generate negative numbers when fetching the id from mirror. This creates a problem when comparing and fetching ids across mirrors. This commit tries to get away from using negative ids as much as possible in rrdom's comparisons
Juice10
changed the title
Member
|
Is this PR also a fix for #917? |
YunFeng0817
approved these changes
Jul 24, 2022
Member
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
The negative ids part looks good to me.
Co-authored-by: Yun Feng <[email protected]>
Member
Author
@Mark-Fenng I don't think so, I tried replaying the JSON Blobs on my branch and on rrwebdebug and they look the same. |
This way we don't accidentally think of them as mirror misses
Member
Author
|
I set the first unserialised id to be -2 so its clear when an id gets returned from the mirror if it is a mirror miss or an unserialised id |
YunFeng0817
approved these changes
Jul 26, 2022
Member
YunFeng0817
left a comment
YunFeng0817
left a comment
There was a problem hiding this comment.
Congrats, you figured out the method to fix the test failure. Your solution also looks good.
Member
Author
|
Thanks @Mark-Fenng! |
Yuyz0112
approved these changes
Jul 31, 2022
Member
Yuyz0112
left a comment
Yuyz0112
left a comment
There was a problem hiding this comment.
Nice patch! Let's merge this after a rebase.
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iframes get inserted they create untracked elements, both on the dom and rrdom side.
Because they are untracked they generate negative numbers when fetching the id from mirror.
This creates a problem when comparing and fetching ids across mirrors.
This PR tries to get away from using negative ids as much as possible in rrdom's comparisons.
PR also adds more test coverage for inlining images.
Also fixes recording of iframe mutations once the page gets reloaded