Skip to content

feat: add a destroy function to destroy the whole player #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2022
Merged

feat: add a destroy function to destroy the whole player #953

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c774498
feat: add a destroy function to destroy the whole player
YunFeng0817 Aug 11, 2022
d83b58e
doc: update guidance document
YunFeng0817 Aug 11, 2022
34f9628
Update packages/rrweb/src/replay/index.ts
YunFeng0817 Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/rrweb/src/replay/index.ts 
Co-authored-by: Justin Halsall <[email protected]>
  • Loading branch information
@YunFeng0817 @Juice10
YunFeng0817 and Juice10 authored Aug 11, 2022
commit 34f96281bf9b44c945162bc53dff0d75522f5875
2 changes: 1 addition & 1 deletion packages/rrweb/src/replay/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ export class Replayer {

public resume(timeOffset = 0) {
console.warn(
`The 'resume' was departed in 1.0. Please use 'play' method which has the same interface.`,
`The 'resume' was deprecated in 1.0. Please use 'play' method which has the same interface.`,
);
this.play(timeOffset);
this.emitter.emit(ReplayerEvents.Resume);
Expand Down