Skip to content

fix: add mutation lost in slimDOMOptions #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

fix: add mutation lost in slimDOMOptions #994

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
595d90e
fix: add mutation lost in slimDOMOptions
wfk007 Sep 8, 2022
243a80a
fix: slimDOMOptions-mutation-lost
wfk007 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: slimDOMOptions-mutation-lost
  • Loading branch information
@wfk007
wfk007 committed Sep 9, 2022
commit 243a80a088c0e254aee636e9c6b0049345d0d4cf
9 changes: 5 additions & 4 deletions packages/rrweb-snapshot/src/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,14 +1014,15 @@ export function serializeNodeWithId(
} else {
id = genId();
}
if (id === IGNORED_NODE) {
return null; // slimDOM
}

const serializedNode = Object.assign(_serializedNode, { id });

// add IGNORED_NODE to mirror to track nextSiblings
mirror.add(n, serializedNode);

if (id === IGNORED_NODE) {
return null; // slimDOM
}

if (onSerialize) {
onSerialize(n);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/rrweb/src/record/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export default class MutationBuffer {
const getNextId = (n: Node): number | null => {
let ns: Node | null = n;
let nextId: number | null = IGNORED_NODE; // slimDOM: ignored
while (nextId === IGNORED_NODE || nextId === -1) {
while (nextId === IGNORED_NODE) {
ns = ns && ns.nextSibling;
nextId = ns && this.mirror.getId(ns);
}
Expand Down