Skip to content

Errno usage is wrong, replace it with textual error codes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Errno usage is wrong, replace it with textual error codes #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e8c41a
Use EEXIST code rather than errno of 17.
p Dec 17, 2012
1bf5566
Convert remaining errno usage to textual codes
p Dec 17, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions fsdocs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function FSDocs(location) {
// FIXME: move into an open method or something like that
try {
fs.mkdirSync(this.location, 0700);
} catch (e) { if (typeof e !== 'object' || e.errno !== 17) throw e; }
} catch (e) { if (typeof e !== 'object' || e.code !== 'EEXIST') throw e; }
}

FSDocs.prototype = {
Expand All @@ -50,7 +50,7 @@ FSDocs.prototype = {
while ((p = dirname.indexOf('/', ++p)) !== -1) {
try {
fs.mkdirSync(this.location+'/'+dirname.substr(0, p), mode);
} catch (e) { if (typeof e !== 'object' || e.errno !== 17) throw e; }
} catch (e) { if (typeof e !== 'object' || e.code !== 'EEXIST') throw e; }
}
},

Expand All @@ -61,7 +61,7 @@ FSDocs.prototype = {
p = dirname.indexOf('/', ++p);
if (p === -1) return callback();
fs.mkdir(location+'/'+dirname.substr(0, p), mode, function (err) {
if (err && (typeof err !== 'object' || err.errno !== 17)) {
if (err && (typeof err !== 'object' || err.code !== 'EEXIST')) {
callback(err);
} else {
next();
Expand All @@ -77,7 +77,7 @@ FSDocs.prototype = {
((version && version > 0) ? version : 'current')+'.json';
fs.readFile(filename, 'utf8', function(err, data) {
if (err) {
if (typeof err === 'object' && (err.errno === 9 || err.errno === 2))
if (typeof err === 'object' && (err.code === 'EBADF' || err.code === 'ENOENT'))
err = null;
return callback && callback(err, null);
}
Expand All @@ -92,7 +92,7 @@ FSDocs.prototype = {
try {
return JSON.parse(fs.readFileSync(filename));
} catch (e) {
if (typeof e === 'object' && (e.errno === 9 || e.errno === 2))
if (typeof e === 'object' && (e.code === 'EBADF' || e.code === 'ENOENT'))
return null;
throw e;
}
Expand Down Expand Up @@ -128,7 +128,7 @@ FSDocs.prototype = {

// lock the entry
fs.link(tempname, lockfile, function(e) {
if (e && typeof e === 'object' && e.errno === 17) {
if (e && typeof e === 'object' && e.code === 'EEXIST') {
// someone else already has the lock (we where too slow)
return fs.unlink(tempname, callback);
} else if (e) { return callback(e); }
Expand All @@ -137,7 +137,7 @@ FSDocs.prototype = {
fs.link(tempname, versionname, function(e) {

if (e) {
if (typeof e === 'object' && e.errno === 17) {
if (typeof e === 'object' && e.code === 'EEXIST') {
// someone else wrote this version before we did
fs.unlink(tempname, function(e) {
fs.unlink(lockfile, function(){ callback(e) });
Expand Down Expand Up @@ -192,7 +192,7 @@ FSDocs.prototype = {
return true;
} catch (e) {
// someone else wrote this version before we did
if (typeof e === 'object' && e.errno === 17) {
if (typeof e === 'object' && e.code === 'EEXIST') {
fs.unlinkSync(tempname);
return false;
}
Expand All @@ -203,7 +203,7 @@ FSDocs.prototype = {
} catch (e) {
fs.unlinkSync(tempname);
// someone else already has the lock (we where too slow)
if (typeof e === 'object' && e.errno === 17)
if (typeof e === 'object' && e.code === 'EEXIST')
return false;
throw e;
}
Expand Down